Skip to content

Fix SolidStart autoconfig for projects using version 2.0.0-alpha or later#12733

Merged
dario-piotrowicz merged 1 commit intomainfrom
dario/autoconfig-solidstart-v2-fix
Mar 3, 2026
Merged

Fix SolidStart autoconfig for projects using version 2.0.0-alpha or later#12733
dario-piotrowicz merged 1 commit intomainfrom
dario/autoconfig-solidstart-v2-fix

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Mar 2, 2026

SolidStart v2.0.0-alpha introduced a breaking change where configuration moved from app.config.(js|ts) to vite.config.(js|ts). This PR updates Wrangler's autoconfig to instead detect the installed SolidStart version and based on it update the appropriate configuration file


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: fixing a broken/expected behavior

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2026

🦋 Changeset detected

Latest commit: 937b693

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

✅ All changesets look good

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 2, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12733

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12733

miniflare

npm i https://pkg.pr.new/miniflare@12733

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12733

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12733

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12733

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12733

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12733

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12733

wrangler

npm i https://pkg.pr.new/wrangler@12733

commit: 2ee7fc5

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review March 3, 2026 10:32
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner March 3, 2026 10:32
@workers-devprod
Copy link
Contributor

workers-devprod commented Mar 3, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 3, 2026
@dario-piotrowicz dario-piotrowicz merged commit d672e2e into main Mar 3, 2026
67 of 79 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/autoconfig-solidstart-v2-fix branch March 3, 2026 17:14
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants