Skip to content

Add support for connect handler in vitest and vite tests#12802

Open
fhanau wants to merge 2 commits intomainfrom
felix/030526-connect-handler-p2
Open

Add support for connect handler in vitest and vite tests#12802
fhanau wants to merge 2 commits intomainfrom
felix/030526-connect-handler-p2

Conversation

@fhanau
Copy link

@fhanau fhanau commented Mar 7, 2026

Follow-up to #12775 and part of EW-9330. Updates tests so that the connect handler is marked as reserved and as a potential member of the WorkerEntrypoint class. Needs cloudflare/workerd#6059 to land first, which in turn requires #12775.


  • Tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Feature is behind experimental compat flag for now.

Open with Devin

fhanau added 2 commits March 7, 2026 09:23
This is needed to add initial support for the connect handler in workerd
(experimental-only for now).
@fhanau fhanau requested a review from a team as a code owner March 7, 2026 20:12
@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2026

⚠️ No Changeset found

Latest commit: 352756b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod
Copy link
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/shared/external-service.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/src/workers/runner-worker/keys.ts: [@cloudflare/wrangler]
  • packages/vitest-pool-workers/src/worker/entrypoints.ts: [@cloudflare/wrangler]

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 7, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12802

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12802

miniflare

npm i https://pkg.pr.new/miniflare@12802

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12802

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12802

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12802

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12802

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12802

wrangler

npm i https://pkg.pr.new/wrangler@12802

commit: 01f08c9

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

}

const WORKER_ENTRYPOINT_KEYS = [
"tailStream",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This is only being removed as it was duplicated in the list so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants