Skip to content

chore(local-explorer-ui): Add TailwindCSS ESLint & Prettier plugins#12819

Merged
NuroDev merged 26 commits intomainfrom
workers-sdk-local-explorer-frontend-linting
Mar 11, 2026
Merged

chore(local-explorer-ui): Add TailwindCSS ESLint & Prettier plugins#12819
NuroDev merged 26 commits intomainfrom
workers-sdk-local-explorer-frontend-linting

Conversation

@NuroDev
Copy link
Member

@NuroDev NuroDev commented Mar 9, 2026

Fixes DEVX-2471.

Changes

  • Added prettier-plugin-tailwindcss to workspace dependencies
  • Update Prettier config to use prettier-plugin-tailwindcss on all local explorer files
  • Added eslint-plugin-tailwindcss to local explorer dev dependencies
  • Updated local explorer ESLint config to use eslint-plugin-tailwindcss
  • Ran Prettier & ESLint to apply all needed fixes
    • The majority of the tweaks / changes here are fixing TailwindCSS class ordering / removing arbitrary values

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: Internal tooling change
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Internal tooling change

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2026

⚠️ No Changeset found

Latest commit: ac91bb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 9, 2026

I'm Bonk, and I've done a quick review of your PR.

This PR adds TailwindCSS ESLint and Prettier plugins scoped to the local-explorer-ui package, without applying formatting changes yet.

One minor issue found:

  1. Inconsistent function lists between ESLint and Prettier configs — The ESLint callees setting includes "ctl" but the Prettier tailwindFunctions option doesn't. If someone uses ctl(), ESLint would flag ordering issues that Prettier can't auto-fix. Posted a suggestion to align the two lists.

Everything else looks good — the plugin ordering is correct (prettier-plugin-tailwindcss is last as required), the tailwindStylesheet is properly scoped via overrides, and the lockfile is consistent.

github run

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 9, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12819

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12819

miniflare

npm i https://pkg.pr.new/miniflare@12819

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12819

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12819

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12819

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12819

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12819

wrangler

npm i https://pkg.pr.new/wrangler@12819

commit: 9ea8cea

@NuroDev NuroDev marked this pull request as ready for review March 10, 2026 11:30
@NuroDev NuroDev requested a review from a team as a code owner March 10, 2026 11:30
@workers-devprod
Copy link
Contributor

workers-devprod commented Mar 10, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@NuroDev NuroDev requested a review from emily-shen March 10, 2026 12:25
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 10, 2026
@NuroDev NuroDev merged commit c648dc5 into main Mar 11, 2026
45 of 51 checks passed
@NuroDev NuroDev deleted the workers-sdk-local-explorer-frontend-linting branch March 11, 2026 15:48
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants