Skip to content

fix(vitest-pool-workers): update peer dependency for vitest to 4.1#12867

Merged
edmundhung merged 2 commits intomainfrom
edmundhung/vpw-peer-dependency-fix
Mar 12, 2026
Merged

fix(vitest-pool-workers): update peer dependency for vitest to 4.1#12867
edmundhung merged 2 commits intomainfrom
edmundhung/vpw-peer-dependency-fix

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Mar 12, 2026

Fixes #11632.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no feature change

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2026

⚠️ No Changeset found

Latest commit: 50e1bc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 12, 2026

I'm Bonk, and I've done a quick review of your PR.

This PR bumps vitest-related dependencies from 4.1.0-beta.4 to 4.1.0 (stable) across peer dependencies, the pnpm catalog, and the lockfile, and adds a changelog entry about it.

Issue found:

  1. Changeset/peer-dep mismatch: The changeset at .changeset/many-fishes-raise.md:57 claims the peer dependency is vitest@^4.1.0 (caret range), but package.json pins it to exactly 4.1.0. This will mislead users into thinking newer vitest 4.x releases (e.g. 4.1.1, 4.2.0) will work, when they'll actually get a peer dependency warning. I posted a suggestion to either fix the docs or widen the range.

github run

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 12, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12867

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12867

miniflare

npm i https://pkg.pr.new/miniflare@12867

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12867

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12867

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12867

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12867

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12867

wrangler

npm i https://pkg.pr.new/wrangler@12867

commit: 54ad4fb

@edmundhung edmundhung marked this pull request as ready for review March 12, 2026 17:10
@edmundhung edmundhung requested a review from a team as a code owner March 12, 2026 17:10
@workers-devprod
Copy link
Contributor

workers-devprod commented Mar 12, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 12, 2026
@edmundhung edmundhung merged commit de6e6b1 into main Mar 12, 2026
54 of 69 checks passed
@edmundhung edmundhung deleted the edmundhung/vpw-peer-dependency-fix branch March 12, 2026 17:15
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants