Remove superfluous adjective from --json description#12894
Merged
petebacondarwin merged 2 commits intomainfrom Mar 16, 2026
Merged
Remove superfluous adjective from --json description#12894petebacondarwin merged 2 commits intomainfrom
petebacondarwin merged 2 commits intomainfrom
Conversation
"Clean" is not a meaningful description of what the `--json` flag does. What does it mean for JSON to be "clean"? What would it mean for it to instead be "unclean"? This was written once and then copy-pasted everywhere. Let's remove it once and for all.
🦋 Changeset detectedLatest commit: 76847d4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Contributor
|
LGTM |
nikitassharma
approved these changes
Mar 13, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
approved these changes
Mar 14, 2026
Contributor
|
Thanks Gregory. It does need a changeset though. |
Member
Author
Added |
Contributor
|
✅ All changesets look good |
gpanders
force-pushed
the
ganders/pnuxqwnpklos
branch
from
6944d54 to
76847d4
Compare
petebacondarwin
approved these changes
Mar 16, 2026
Contributor
|
Merging even though D1 and Cloudchamber have not approved via the new approval flow (Greg is from Cloudchamber team!) |
Merged
petebacondarwin
pushed a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"clean" is not a meaningful description of what the
--jsonflag does. What does it mean for JSON to be "clean"? What would it mean for it to instead be "unclean"?This was written once and then copy-pasted everywhere. Let's remove it once and for all.