fix(local-explorer-ui): Add 404 & 500 error components#13158
Conversation
🦋 Changeset detectedLatest commit: 4a5f9c0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I've reviewed all the changes thoroughly. Let me analyze the PR:
Everything here looks correct and straightforward. The No logic bugs, no security issues, no backward compatibility concerns. LGTM |
|
✅ All changesets look good |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
packages/local-explorer-ui/src/routes/do/$className/$objectId.tsx
Outdated
Show resolved
Hide resolved
|
Codeowners approval required for this PR:
Show detailed file reviewers |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes N/A.
Summary
Currently if you visit a route that doesn't exist, or try to access a resource, like a KV or D1 binding, that doesn't exist it crashes the app and shows the generic error message.
Instead we now show a controlled 404 message for unknown routes like
/fooand a "Resource not found" error message for when trying to access resources that don't exist.Additionally this both:
A picture of a cute animal (not mandatory, but encouraged)