Skip to content

Recognize Hydrogen as a known unsupported framework in autoconfig#13187

Merged
dario-piotrowicz merged 2 commits intomainfrom
dario/DEVX-2506/autoconfig-hydrogen
Apr 27, 2026
Merged

Recognize Hydrogen as a known unsupported framework in autoconfig#13187
dario-piotrowicz merged 2 commits intomainfrom
dario/DEVX-2506/autoconfig-hydrogen

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Apr 1, 2026

Fixes https://jira.cfdata.org/browse/DEVX-2506

Previously, Hydrogen projects were incorrectly identified as React Router (since Hydrogen uses React Router under the hood), leading to a confusing autoconfig experience. Hydrogen is now recognized as a distinct unsupported framework, so users see a clear message that Hydrogen is not yet supported instead of being guided through React Router configuration.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: self explanatory improvement

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 1, 2026

🦋 Changeset detected

Latest commit: 4b4f76a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 1, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 1, 2026

@dario-piotrowicz Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 1, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13187

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13187

miniflare

npm i https://pkg.pr.new/miniflare@13187

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13187

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13187

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13187

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13187

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13187

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13187

wrangler

npm i https://pkg.pr.new/wrangler@13187

commit: 4b4f76a

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2506/autoconfig-hydrogen branch from e319b93 to 514a5f5 Compare April 1, 2026 12:15
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review April 1, 2026 13:45
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner April 1, 2026 13:45
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 1, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we upstream this?

Comment thread packages/wrangler/src/autoconfig/details/framework-detection.ts Outdated
@dario-piotrowicz
Copy link
Copy Markdown
Member Author

Converted to draft since this might be unneeded after the upstream fix

@dario-piotrowicz dario-piotrowicz marked this pull request as draft April 9, 2026 07:52
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2506/autoconfig-hydrogen branch from 514a5f5 to f51c5dc Compare April 24, 2026 14:20
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Changeset Review

File: .changeset/lemon-hoops-stick.md

✅ All changesets look good


Review Notes

  • Version Type (patch): Appropriate for this bug fix/improvement to framework detection
  • Changelog Quality: Meaningful description explaining the issue (incorrect React Router detection) and the fix (clearer unsupported message for Hydrogen)
  • Markdown Headers: No h1/h2/h3 headers found
  • Analytics: N/A - not an analytics change
  • Dependabot: N/A - not a dependency update
  • Experimental Features: N/A - not an experimental feature

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2506/autoconfig-hydrogen branch from f51c5dc to c118861 Compare April 24, 2026 14:23
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review April 24, 2026 14:26
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Comment thread packages/wrangler/src/autoconfig/frameworks/index.ts Outdated
Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>
@dario-piotrowicz dario-piotrowicz merged commit fcc491a into main Apr 27, 2026
60 of 61 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-2506/autoconfig-hydrogen branch April 27, 2026 10:27
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants