MQ-1273: Add metadata with metrics to queue broker response in miniflare#13335
MQ-1273: Add metadata with metrics to queue broker response in miniflare#13335KennethRuan merged 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: c22ddbf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Changeset ReviewSummary✅ All changesets look good Reviewed Changesets
Notes
|
|
Review posted successfully on PR #13335. Here's a summary of the two issues I flagged:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
LGTM from Queues' side |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
LGTM, with some minor comments 🙂
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes https://jira.cfdata.org/browse/MQ-1273.
These changes keep the Miniflare Queues implementation up to date with its production counterpart.
There are currently changes in
workerdthat are gated behind an experimental flag (See PRs for MQ-1154, MQ-1200, MQ-1202). When those features are ungated,miniflarechanges will need to be up to date so that local development withwrangler devwill match intended behaviour.This PR adds an adapted implementation of metrics that simulates the production experience.
workerdA picture of a cute animal (not mandatory, but encouraged)
