fix: preserve NonRetryableError message when compat flag is enabled#13560
Merged
petebacondarwin merged 8 commits intocloudflare:mainfrom Apr 22, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: abc0451 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
penalosa
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
petebacondarwin
requested changes
Apr 17, 2026
vaishnav-mk
force-pushed
the
vaish/fix-nonretryable-error-message
branch
from
cb2fa30 to
8b56879
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
vaishnav-mk
force-pushed
the
vaish/fix-nonretryable-error-message
branch
from
8b56879 to
396be46
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
vaishnav-mk
force-pushed
the
vaish/fix-nonretryable-error-message
branch
2 times, most recently
from
71252fa to
0cbbdff
Compare
petebacondarwin
approved these changes
Apr 17, 2026
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
Looking much cleaner. It's a shame that one must pass through the compat flags but I can't think of a more straightforward approach.
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
vaishnav-mk
force-pushed
the
vaish/fix-nonretryable-error-message
branch
from
0cbbdff to
965ee4f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pombosilva
reviewed
Apr 21, 2026
pombosilva
approved these changes
Apr 21, 2026
workers-devprod
approved these changes
Apr 21, 2026
Contributor
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Contributor
|
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
Author
i switched to |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the NonRetryableError message being replaced with a generic error message in local dev
When the workflows_preserve_non_retryable_error_message compatibility flag is enabled, NonRetryableError now preserves the original error name and message instead of replacing it with a generic WorkflowFatalError message
workflows_preserve_non_retryable_error_message). Docs will be added when it graduates to a compat date.A picture of a cute animal (not mandatory, but encouraged)
