[wrangler] Expand telemetry arg allow list to restore dropped boolean flags#13576
Merged
[wrangler] Expand telemetry arg allow list to restore dropped boolean flags#13576
Conversation
🦋 Changeset detectedLatest commit: d41a3ab The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
petebacondarwin
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
✅ All changesets look good SummaryReviewed 26 changeset files: Validated Changesets (16)
Skipped (Dependency Updates - per guidelines)
Checks Passed
|
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
I posted a review on PR #13576 with one actionable finding:
Everything else looks correct — all 32 boolean flags are verified as genuinely boolean in their yargs definitions, the changeset is properly formatted, and the test exercises the full sanitization pipeline. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
approved these changes
Apr 17, 2026
workers-devprod
approved these changes
Apr 17, 2026
Contributor
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
dario-piotrowicz
approved these changes
Apr 17, 2026
MattieTK
force-pushed
the
expand-telemetry-arg-allow-list
branch
from
1f7d4d7 to
34aa994
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Common boolean flags like --remote, --json, --dry-run, --force and others were unintentionally dropped from sanitizedArgs when argument sanitisation was introduced. The COMMAND_ARG_ALLOW_LIST was too conservative, only permitting --format and --log-level globally. Boolean flags are inherently safe (values are only true/false), so these have been added back. Fixed-choice args (--local-protocol, etc.) have also been added with their known value sets.
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
MattieTK
force-pushed
the
expand-telemetry-arg-allow-list
branch
from
5146aba to
d41a3ab
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where common CLI flags like
--remote,--json,--dry-run,--force, and many others were being silently dropped fromsanitizedArgsin telemetry events.When argument sanitisation was introduced, the
COMMAND_ARG_ALLOW_LISTwas very conservative — only--formatand--log-levelwere permitted globally. Any arg not in the list had its value completely dropped fromsanitizedArgsbysanitizeArgValues. These flags were previously tracked and were unintentionally removed as part of the sanitisation process.This PR expands the allow list with:
*entry (inherently safe — values are onlytrue/false):json,force,remote,local,dryRun,preview,yes,skipConfirmation,noBundle,bundle,minify,latest,uploadSourceMaps,legacyEnv,liveReload,keepVars,logpush,strict,testScheduled,showInteractiveDevSession,skipCaching,commitDirty,includeRuntime,includeEnv,strictVars,check,useRemote,updateConfig,nodeCompat,enableContainers,xAutoconfig,ignoreDefaultslocalProtocolandupstreamProtocolfordev(["http", "https"]),containersRolloutfordeploy(["immediate", "gradual"])An integration test has been added that exercises the full sanitisation pipeline (sanitizeArgKeys → getAllowedArgs → sanitizeArgValues) against the real
COMMAND_ARG_ALLOW_LISTto verify flags like--remotenow pass through correctly.