[wrangler] Prioritize CLOUDFLARE_ACCOUNT_ID over cached account id for Pages commands#13628
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: 875f5a2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
UnknownError: ProviderInitError |
|
@emily-shen Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
fbd1308 to
cf6d9ab
Compare
Changeset ReviewReviewed Changesets
|
| Criteria | Status | Notes |
|---|---|---|
| Version Type | ✅ | patch is appropriate for this bug fix |
| Changelog Quality | ✅ | Clear description of the fix, affected commands listed, previous behavior explained |
| Markdown Headers | ✅ | No h1/h2/h3 headers found |
| Analytics | ✅ | N/A - no analytics collection |
| Dependabot | ✅ | N/A - not a dependency update |
| Experimental Features | ✅ | N/A - bug fix for existing functionality |
Summary:
This changeset correctly describes a bug fix where the CLOUDFLARE_ACCOUNT_ID environment variable was not being prioritized over cached account IDs in certain Pages commands. The description clearly lists the affected commands and notes that pages project commands were already working correctly. Good level of detail for users to understand what was fixed.
Overall Result
✅ All changesets look good
|
Codeowners approval required for this PR:
Show detailed file reviewers |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
cf6d9ab to
875f5a2
Compare
Fixes #13590.
Most pages commands previously read the account id from their cached
pages.jsonbefore checking theCLOUDFLARE_ACCOUNT_IDenvironment variable.This is inconsistent with other commands, including the
pages project list/create/deletecommands which already do prioritiseCLOUDFLARE_ACCOUNT_ID.This PR applies the same pattern to the remaining Pages commands:
wrangler pages deploywrangler pages deployment list/deployment deletewrangler pages deployment tailwrangler pages download configwrangler pages secret(put/bulk/delete/list)Tests
Public documentation
Devin PR requested by @emily-shen (eshen@cloudflare.com)
Link to Devin session: https://app.devin.ai/sessions/c2f96415cbf44d12a22dec27fad422b4