Skip to content

[local-explorer-ui] Fix Workflows page (colors, icons, etc)#13654

Merged
emily-shen merged 2 commits intomainfrom
osilva/fix-local-ui-workflows
Apr 27, 2026
Merged

[local-explorer-ui] Fix Workflows page (colors, icons, etc)#13654
emily-shen merged 2 commits intomainfrom
osilva/fix-local-ui-workflows

Conversation

@pombosilva
Copy link
Copy Markdown
Contributor

@pombosilva pombosilva commented Apr 23, 2026

Fixes WOR-1197.

Expanded workflow steps no longer collapse when new steps arrive via polling. Polling also skips state updates when the response data hasn't changed, avoiding unnecessary re-renders.

The miniflare local explorer API now preserves the internal -N counter suffix on step names, giving the UI naturally unique keys. The suffix is stripped only visually when rendering.

Other instance page improvements:

  • Triggering a workflow navigates directly to the new instance's detail page
  • Distinct refresh/restart icons
  • Filter dropdown and action buttons moved to a toolbar below the stats strip
  • Stats strip always visible regardless of filters or instance count
  • Unified status colors (reds, greens, wait-for-event violet)
  • Error card header matches Input params/Output header sizing

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: fixes only

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 23, 2026

🦋 Changeset detected

Latest commit: ccb0629

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 23, 2026

Review posted successfully on PR #13654 with two actionable findings:

  1. getStepKey produces non-unique keys${step.type}-${step.name} will collide when a workflow has multiple steps with the same type and name (retries, repeated step names). This breaks React reconciliation and causes the wrong row to expand. Suggested adding the index back as a disambiguator.

  2. Unsafe cast in CreateInstanceDialog(response.data?.result as { id: string }).id will throw if result is undefined. Suggested a safe optional chain with a fallback.

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 23, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13654

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13654

miniflare

npm i https://pkg.pr.new/miniflare@13654

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13654

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13654

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13654

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13654

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13654

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13654

wrangler

npm i https://pkg.pr.new/wrangler@13654

commit: ccb0629

@pombosilva pombosilva force-pushed the osilva/fix-local-ui-workflows branch 3 times, most recently from 0497749 to dd45165 Compare April 24, 2026 11:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

✅ All changesets look good

Review Summary

.changeset/fix-workflows-instance-ui.md

  • Package: @cloudflare/local-explorer-ui
  • Version Type: patch (appropriate for bug fix)
  • Quality: Good descriptive title and body explaining the UX improvements
  • Headers: No forbidden h1/h2/h3 headers

.changeset/fix-workflows-step-name-suffix.md

  • Package: miniflare
  • Version Type: patch (appropriate for bug fix)
  • Quality: Clear description of API behavior change
  • Headers: No forbidden h1/h2/h3 headers

Both changesets follow the established format guidelines with proper frontmatter, conventional commit style prefixes, and meaningful descriptions of the user-facing changes.

@pombosilva pombosilva force-pushed the osilva/fix-local-ui-workflows branch from dd45165 to 9398c4b Compare April 24, 2026 11:44
@pombosilva pombosilva marked this pull request as ready for review April 24, 2026 12:06
@workers-devprod workers-devprod requested review from a team and jamesopstad and removed request for a team April 24, 2026 12:06
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 24, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Comment thread packages/local-explorer-ui/src/components/workflows/StatusBadge.tsx
Comment thread packages/local-explorer-ui/src/components/workflows/StepRow.tsx Outdated
Comment thread packages/local-explorer-ui/src/routes/workflows/$workflowName/$instanceId.tsx Outdated
devin-ai-integration[bot]

This comment was marked as resolved.

@pombosilva pombosilva force-pushed the osilva/fix-local-ui-workflows branch from 46a3765 to 4be577c Compare April 27, 2026 10:45
@pombosilva pombosilva force-pushed the osilva/fix-local-ui-workflows branch from 4be577c to ccb0629 Compare April 27, 2026 10:53
@pombosilva pombosilva requested a review from emily-shen April 27, 2026 10:57
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 27, 2026
@emily-shen emily-shen merged commit 6d27479 into main Apr 27, 2026
60 checks passed
@emily-shen emily-shen deleted the osilva/fix-local-ui-workflows branch April 27, 2026 12:49
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants