fix(workers-shared): guard against undefined user_worker static_routing rules#13668
Merged
for-the-kidz merged 2 commits intomainfrom Apr 24, 2026
Merged
fix(workers-shared): guard against undefined user_worker static_routing rules#13668for-the-kidz merged 2 commits intomainfrom
for-the-kidz merged 2 commits intomainfrom
Conversation
The router-worker's include-rule evaluation passed config.static_routing.user_worker directly to generateStaticRoutingRuleMatcher, which iterates with for...of. When static_routing was configured but user_worker was undefined, this threw `TypeError: rules is not iterable`, breaking all requests. The adjacent asset_worker branch on line 207 already applies `?? []`; this brings the user_worker branch into parity. Fixes WC-5014 / Sentry #31445454.
🦋 Changeset detectedLatest commit: 31a3a44 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
edmundhung
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
✅ All changesets look good Summary:
All changesets follow the guidelines:
|
Contributor
|
The fix is clear and correct. The change is a one-character diff ( LGTM |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
WillTaylorDev
approved these changes
Apr 24, 2026
edmundhung
reviewed
Apr 24, 2026
edmundhung
approved these changes
Apr 24, 2026
Member
edmundhung
left a comment
edmundhung
left a comment
There was a problem hiding this comment.
Looks good. Just one nitpick.
workers-devprod
approved these changes
Apr 24, 2026
Contributor
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Merged
vaishnav-mk
pushed a commit
to vaishnav-mk/workers-sdk
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The router-worker's include-rule evaluation passed config.static_routing.user_worker directly to generateStaticRoutingRuleMatcher, which iterates with for...of. When static_routing was configured but user_worker was undefined, this threw
TypeError: rules is not iterable, breaking all requests.The adjacent asset_worker branch on line 207 already applies
?? []; this brings the user_worker branch into parity.A picture of a cute animal (not mandatory, but encouraged)
