wrangler types --check fails with Invalid value: true

[alexanderniebuhr]

Fixes #13694

Root cause

wrangler 4.85.0 introduced a --check flag that reads back the command stored in the worker-configuration.d.ts header comment (e.g. wrangler types --include-runtime --include-env --strict-vars) and re-parses it with yargs to reconstruct the original arguments.

The problem: yargs parses --include-runtime, --include-env, and --strict-vars as native boolean true, but unsafeParseBooleanString — the internal helper used to interpret those values — only handles string inputs. Passing a boolean throws ParseError: Invalid value: true.

Fix

Add an early boolean passthrough in unsafeParseBooleanString:

if (typeof value === "boolean") {
  return value;
}

This is a minimal, non-breaking fix that handles the case where yargs already coerced the flag value to a boolean, which is the correct yargs behavior for boolean flags.

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because: a boolean should be a boolean
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bug fix

A picture of a cute animal (not mandatory, but encouraged)

---

[changeset-bot]

🦋 Changeset detected

Latest commit: bbcf6cc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[workers-devprod]

Codeowners approval required for this PR:

• ✅ @cloudflare/wrangler

Show detailed file reviewers

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13695

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13695

miniflare

npm i https://pkg.pr.new/miniflare@13695

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13695

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13695

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13695

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13695

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13695

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13695

wrangler

npm i https://pkg.pr.new/wrangler@13695

commit: bbcf6cc

[edmundhung]

Thanks for the fix, @alexanderniebuhr! The solution looks good to me. Could you add a regression test in packages/wrangler/e2e/types.test.ts and a patch changeset?

[alexanderniebuhr]

I hope the regression test and changeset are good enough, please feel free to adapt them if needed.

[workers-devprod]

Codeowners reviews satisfied

[edmundhung]

Thanks for the fix, @alexanderniebuhr! 😄