Skip to content

fix(wrangler): support Flagship bindings with wrangler preview#13818

Merged
dario-piotrowicz merged 1 commit intocloudflare:mainfrom
1000hz:support-flagship-previews
May 5, 2026
Merged

fix(wrangler): support Flagship bindings with wrangler preview#13818
dario-piotrowicz merged 1 commit intocloudflare:mainfrom
1000hz:support-flagship-previews

Conversation

@1000hz
Copy link
Copy Markdown
Contributor

@1000hz 1000hz commented May 5, 2026

Fixes WC-5095.

Flagship bindings recently shipped for standard Worker deployments, but the Preview-specific config path was missed. This fixes wrangler preview so Workers with Flagship bindings can create Preview deployments and use preview-specific Flagship app IDs.

  • Accept flagship bindings inside the previews block.
  • Include Preview Flagship bindings in the Preview deployment env payload.
  • Display the Flagship app ID in Preview deployment output.
  • Add regression coverage for config validation and wrangler preview deployment behavior.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this fixes Preview support for an existing Wrangler config binding without changing the public configuration shape beyond making the existing flagship binding work in previews.

Open in Devin Review

@1000hz 1000hz requested a review from workers-devprod as a code owner May 5, 2026 15:52
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

🦋 Changeset detected

Latest commit: 316ced2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

🦋 Changeset detected

Latest commit: 316ced2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod requested review from a team and penalosa and removed request for a team May 5, 2026 15:53
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented May 5, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 5, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13818

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13818

miniflare

npm i https://pkg.pr.new/miniflare@13818

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13818

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13818

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13818

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13818

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13818

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13818

wrangler

npm i https://pkg.pr.new/wrangler@13818

commit: 316ced2

Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 5, 2026
@dario-piotrowicz dario-piotrowicz merged commit 9f532f7 into cloudflare:main May 5, 2026
66 of 68 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants