Skip to content

fix(wrangler): hide multi-env warning when env is set via CLOUDFLARE_ENV#13827

Merged
petebacondarwin merged 31 commits into
cloudflare:mainfrom
greyvugrin:fix-workers-deploy-warning-cloudflare-env
May 14, 2026
Merged

fix(wrangler): hide multi-env warning when env is set via CLOUDFLARE_ENV#13827
petebacondarwin merged 31 commits into
cloudflare:mainfrom
greyvugrin:fix-workers-deploy-warning-cloudflare-env

Conversation

@greyvugrin
Copy link
Copy Markdown
Contributor

@greyvugrin greyvugrin commented May 5, 2026

Changes:

  • Updated tests for wrangler commands to account for this use case (env specified through CLOUDFLARE_ENV)
  • Added fix that leverages computed targetEnvironment
  • Updated warning message to mention CLOUDFLARE_ENV
  • Updated tests to use a helper for the warning message text to check against

Example of failures prior to adjusting the source code:
Screenshot 2026-05-05 at 3 36 11 PM


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this updates behavior to match existing docs
sierra-nicole-narvaeth-aM7r5lqKhiY-unsplash

Photo by Sierra NiCole Narvaeth on Unsplash

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

🦋 Changeset detected

Latest commit: 7f31ab5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@greyvugrin greyvugrin marked this pull request as ready for review May 6, 2026 00:03
@workers-devprod workers-devprod requested review from a team and edmundhung and removed request for a team May 6, 2026 00:03
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented May 6, 2026

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • .changeset/mighty-planes-give.md: [@cloudflare/wrangler]
  • packages/workers-utils/src/config/config-helpers.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/index.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/environments.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/secret.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/bulk.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/delete.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/put.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/versions.deploy.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/versions.upload.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/core/register-yargs-command.ts: [@cloudflare/wrangler]

devin-ai-integration[bot]

This comment was marked as resolved.

Comment thread packages/wrangler/src/__tests__/deploy/environments.test.ts Outdated
Comment thread packages/wrangler/src/__tests__/helpers/multi-env-warning.ts Outdated
Comment thread packages/wrangler/src/__tests__/versions/secrets/bulk.test.ts Outdated
Comment thread packages/wrangler/src/__tests__/versions/secrets/delete.test.ts Outdated
Comment thread packages/wrangler/src/core/register-yargs-command.ts Outdated
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk May 6, 2026
@github-project-automation github-project-automation Bot moved this from Untriaged to In Review in workers-sdk May 6, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13827

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13827

miniflare

npm i https://pkg.pr.new/miniflare@13827

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13827

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13827

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13827

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13827

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13827

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13827

wrangler

npm i https://pkg.pr.new/wrangler@13827

commit: 7f31ab5

@greyvugrin greyvugrin requested a review from petebacondarwin May 7, 2026 17:52
@petebacondarwin petebacondarwin force-pushed the fix-workers-deploy-warning-cloudflare-env branch from 3ae1d5e to 26e6134 Compare May 7, 2026 19:12
Comment thread packages/wrangler/src/core/register-yargs-command.ts
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented May 13, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with me. Looks good now.

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from In Review to Approved in workers-sdk May 14, 2026
@petebacondarwin petebacondarwin merged commit 8f5cdb1 into cloudflare:main May 14, 2026
54 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants