[wrangler] Use dedicated secrets-bulk PATCH endpoint for secrets#13964
Merged
petebacondarwin merged 2 commits intoMay 20, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 2fdd042 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
james-elicx
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
danielrs
force-pushed
the
drivas/WC-5169-wrangler-secret-bulk-api
branch
from
a923def to
1edecd9
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
approved these changes
May 19, 2026
workers-devprod
approved these changes
May 19, 2026
Contributor
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
danielrs
force-pushed
the
drivas/WC-5169-wrangler-secret-bulk-api
branch
from
1edecd9 to
234c760
Compare
petebacondarwin
force-pushed
the
drivas/WC-5169-wrangler-secret-bulk-api
branch
from
a58f3f2 to
6a9201f
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…cret bulk` Replace the workaround that fetched all script settings (GET /settings) and re-patched the full bindings array (PATCH /settings with FormData) with a single PATCH to the new /secrets-bulk endpoint using JSON Merge Patch (RFC 7396). This eliminates the need to read and re-send non-secret bindings, reducing the operation from 2 API calls to 1, removing risk of accidentally disrupting non-secret bindings, and simplifying the implementation from ~100 lines to ~30.
danielrs
force-pushed
the
drivas/WC-5169-wrangler-secret-bulk-api
branch
from
6a9201f to
cba8c70
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked internally: https://jira.cfdata.org/browse/WC-5169
Describe your change...
Replace the workaround that fetched all script settings (GET /settings) and re-patched the full bindings array (PATCH /settings with FormData) with a single PATCH to the new /secrets-bulk endpoint using JSON Merge Patch (RFC 7396).
This eliminates the need to read and re-send non-secret bindings, reducing the operation from 2 API calls to 1, removing risk of accidentally disrupting non-secret bindings, and simplifying the implementation from ~100 lines to ~30.
A picture of a cute animal (not mandatory, but encouraged)