Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: 6b7c683

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6699375717/npm-package-wrangler-4249

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6699375717/npm-package-wrangler-4249

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6699375717/npm-package-wrangler-4249 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6699375717/npm-package-cloudflare-pages-shared-4249

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231025.0 3.20231025.0
workerd 1.20231025.0 1.20231025.0
workerd --version 1.20231025.0 2023-10-25

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz force-pushed the 4183-improve-c3-cli-args-docs branch from f1f9962 to 0f77973 Compare October 27, 2023 11:53
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #4249 (6b7c683) into main (a027b57) will decrease coverage by 0.01%.
Report is 12 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4249      +/-   ##
==========================================
- Coverage   75.39%   75.39%   -0.01%     
==========================================
  Files         223      223              
  Lines       12330    12341      +11     
  Branches     3186     3190       +4     
==========================================
+ Hits         9296     9304       +8     
- Misses       3034     3037       +3     

see 8 files with indirect coverage changes

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review October 27, 2023 16:04
@dario-piotrowicz dario-piotrowicz requested a review from a team October 27, 2023 16:05
Copy link
Contributor

@admah admah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of small suggestions 🚀

Co-authored-by: Adam Murray <admah@users.noreply.github.com>
@dario-piotrowicz dario-piotrowicz merged commit b18a2c0 into main Oct 31, 2023
@dario-piotrowicz dario-piotrowicz deleted the 4183-improve-c3-cli-args-docs branch October 31, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛/🚀 BUG/Feature Request: C3 type Cli arguments handling could/should be improved

3 participants