This repository was archived by the owner on Aug 3, 2023. It is now read-only.
fixes more clippy warnings - #1306
Merged
Merged
Conversation
EverlastingBugstopper
changed the base branch from
alewis/clippy-warnings
to
master
May 20, 2020 20:20
EverlastingBugstopper
force-pushed
the
avery/more-clippy
branch
from
May 20, 2020 20:31
052c56d to
c94a4cf
Compare
ashleymichal
approved these changes
May 20, 2020
dmcgowan
reviewed
May 22, 2020
| } | ||
| let tmp = String::new(); | ||
| let _ = io::stdin().read_to_string(&mut input); | ||
| tmp |
Contributor
There was a problem hiding this comment.
Is this overwriting input with an empty string? I was trying to trace down an empty input when using pipe in 1.9.1, reverting back to 1.9.0 worked for me.
Contributor
Author
There was a problem hiding this comment.
whhooooppss - it looks like that should be tmp not input. probably gonna need another point release for this one. thanks @dmcgowan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gotta catch em all!!!