This repository was archived by the owner on Aug 3, 2023. It is now read-only.
Revert "Allow site key to be configured by environment (#1573)" - #1626
Merged
Conversation
ObsidianMinor
added a commit
that referenced
this pull request
Nov 1, 2020
ObsidianMinor
pushed a commit
to ObsidianMinor/wrangler
that referenced
this pull request
Nov 2, 2020
…)" (cloudflare#1626) This reverts commit bf0601a. Change caused a regression which destroyed deployments. cloudflare#1625
ObsidianMinor
added a commit
that referenced
this pull request
Nov 2, 2020
ObsidianMinor
added a commit
that referenced
this pull request
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit bf0601a.
Change caused a regression which destroyed deployments.
#1625
TODO: Create docs issue. We falsely claim that site key can inherit from env https://developers.cloudflare.com/workers/cli-wrangler/configuration#keys