This repository was archived by the owner on Aug 3, 2023. It is now read-only.
Feat kv commands - #405
Merged
Merged
Conversation
ashleymichal
added
status - work in progress
regression
ashleymichal
requested review from
EverlastingBugstopper,
ashleygwilliams,
gabbifish,
kristianfreeman,
steveklabnik,
xortive and
xtuc
August 6, 2019 14:05
ashleygwilliams
previously approved these changes
Aug 6, 2019
ashleygwilliams
left a comment
ashleygwilliams
left a comment
Contributor
There was a problem hiding this comment.
lgtm. one small question but not a huge deal
steveklabnik
approved these changes
Aug 6, 2019
steveklabnik
approved these changes
Aug 7, 2019
ashleymichal
force-pushed
the
feat-kv-commands
branch
from
August 7, 2019 22:26
1c02235 to
db8eb05
Compare
* implement From for cloudflare-rs Credential -> GlobalUser
* add KV emoji
ashleymichal
force-pushed
the
feat-kv-commands
branch
from
August 7, 2019 22:44
db8eb05 to
b8bc14b
Compare
* Add more helpful messaging when creating namespace; output to put in wrangler.toml
* Print out namespaces list as json by default
* Add reminder to remove binding after calling , also ensure binding names are valid
* Re-order kv commands docs to be more user friendly + Add Getting Started and Concepts sections to kv docs
xtuc
reviewed
Sep 12, 2019
| Your default `wrangler build`, `wrangler preview`, and `wrangler publish` commands will all build with `webpack.dev.js`, as will `wrangler build -e staging`, `wrangler preview -e staging`, and `wrangler publish -e staging`. `wrangler build -e production`, `wrangler preview -e production`, and `wrangler publish -e production` would all use your `webpack.config.js` file. | ||
|
|
||
| ### KV Namespaces with environments | ||
|
|
Contributor
There was a problem hiding this comment.
This file was renamed. I might be wrong but I believe I saw a link to this doc printed out in my terminal.
Contributor
There was a problem hiding this comment.
This is correct
@gabbifish do you mind updating the instances of /docs/environments.md to /docs/content/environments.md?
EverlastingBugstopper
added
status - needs review
and removed
status - work in progress
labels
Allow use of same json file to bulk delete as bulk put
* Ensure that when a subcommand is not provided to a kv: command, do not panic. STILL DISPLAYS HELP INFORMATION WITH --binding AND --namespace-id INFO THAT IS INCONSISTENT WITH USAGE (b/c globals are paired with arggroups here)
ashleymichal
requested review from
EverlastingBugstopper,
ashleygwilliams and
steveklabnik
and removed request for
xortive
September 13, 2019 16:27
| wrangler generate <name> <template> --type=["webpack", "javascript", "rust"] | ||
| ``` | ||
|
|
||
| <<<<<<< HEAD |
Contributor
There was a problem hiding this comment.
resolve conflict in readme
ashleygwilliams
previously approved these changes
Sep 13, 2019
| >>>>>>> master | ||
| #### Publishing the same code to multiple places | ||
|
|
||
| If you would like to be able to publish your code to multiple places, please see the documentation for [environments](https://github.com/cloudflare/wrangler/blob/master/docs/environments.md). |
Contributor
There was a problem hiding this comment.
all instances of docs/environments.md need to be changed to docs/content/environments.md
ashleygwilliams
self-requested a review
September 13, 2019 16:32
ashleymichal
dismissed
ashleygwilliams’s stale review
September 13, 2019 16:42
missed a couple merge conflicts. need new review
EverlastingBugstopper
approved these changes
Sep 13, 2019
EverlastingBugstopper
left a comment
EverlastingBugstopper
left a comment
Contributor
There was a problem hiding this comment.
lgtm! great work :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339. Comprises complete support for KV commands in Wrangler, should close https://github.com/cloudflare/wrangler/milestone/7 also.
keep this branch up to date with master using ui merges rather than rebasing.