Skip to content
This repository was archived by the owner on Aug 3, 2023. It is now read-only.

Reduce output from publish command#584

Merged
EverlastingBugstopper merged 1 commit into
masterfrom
avery/sit-down-be-humble
Sep 13, 2019
Merged

Reduce output from publish command#584
EverlastingBugstopper merged 1 commit into
masterfrom
avery/sit-down-be-humble

Conversation

@EverlastingBugstopper

@EverlastingBugstopper EverlastingBugstopper commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

Fixes #523

This PR improves the messaging of wrangler publish.

Before:

✨  Built successfully, built project size is 517 bytes.
✨  Successfully published your script.
✨  Success! Your worker was successfully published. You can view it at example.com/*

After:

$ wrangler publish
✨  Built successfully, built project size is 523 bytes.
✨  Successfully published your script to example.com/*

@EverlastingBugstopper
EverlastingBugstopper requested a review from a team September 13, 2019 14:27
@EverlastingBugstopper EverlastingBugstopper self-assigned this Sep 13, 2019
xtuc
xtuc approved these changes Sep 13, 2019
View reviewed changes

@xtuc xtuc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Also removes a merge conflict 😄

@EverlastingBugstopper
EverlastingBugstopper merged commit c8c674b into master Sep 13, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the avery/sit-down-be-humble branch September 13, 2019 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@xtuc xtuc xtuc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wrangler publish is a bit too excited

2 participants

@EverlastingBugstopper @xtuc