Always log when delegating to local wrangler install

[mrbbot]

Closes #2302.

When a global wrangler command is executed in a package directory with wrangler installed locally, the command is redirected to the local wrangler install. Whilst sometimes useful, this behaviour is contrary to most other npm CLI packages (and npx wrangler ... should already call the local version if detected). It also makes debugging issues more confusing, as it's not clear which wrangler version is being called. This PR replaces a debug log we already had for this with a regular log, so users (and wrangler developers 😅) know what's going on.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4860c2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/3675287393/npm-package-wrangler-2391

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2391/npm-package-wrangler-2391

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/runs/3675287393/npm-package-wrangler-2391 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/runs/3675287393/npm-package-cloudflare-pages-shared-2391

[petebacondarwin]

LOL - eab9542

[mrbbot]

🤣 Ah... I would say this feature is more confusing than the debug message, as it's not what other Node CLI tools do, but we should probably discuss this. 😅

[codecov]

Codecov Report

Merging #2391 (4860c2d) into main (21bab6b) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
+ Coverage   70.71%   70.74%   +0.03%     
==========================================
  Files         153      153              
  Lines        9751     9751              
  Branches     2550     2550              
==========================================
+ Hits         6895     6898       +3     
+ Misses       2856     2853       -3     

Impacted Files	Coverage Δ
packages/wrangler/src/git-client.ts	81.25% <0.00%> (+4.16%)	⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts	100.00% <0.00%> (+5.26%)	⬆️

[rozenmd]

Part of me wants to revisit this feature, but we implemented so teams could be sure that their commands run on the version specified in their package.json

[petebacondarwin]

The problem is that some people just like to use the global version of stuff.

This is really not a good idea for NodeJS packages. We should be strongly encouraging people to install the version locally and then use npx or equivalent package manager tools to run it.

As long as people use global commands then the best we can do is this sneaky trick.

[JacobMGEvans]

The problem is that some people just like to use the global version of stuff.

This is really not a good idea for NodeJS packages. We should be strongly encouraging people to install the version locally and then use npx or equivalent package manager tools to run it.

As long as people use global commands then the best we can do is this sneaky trick.

+1

[penalosa]

Just to note for future reference, I approved this so we'd get the debug log which will make it clear what Wrangler is doing (and encourage people to use npx for direct invocation)—it seems most of the discussion is about the "sneaky trick" which this debug log points out.