-
Notifications
You must be signed in to change notification settings - Fork 40
feat: fix bug of badge in double check table modal #5484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seungyeoneeee
merged 1 commit into
cloudforet-io:feature-project-alert-manager
from
seungyeoneeee:feature/alert-qa0113
Jan 14, 2025
Merged
feat: fix bug of badge in double check table modal #5484
seungyeoneeee
merged 1 commit into
cloudforet-io:feature-project-alert-manager
from
seungyeoneeee:feature/alert-qa0113
Jan 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
skdud4659
approved these changes
Jan 14, 2025
Member
skdud4659
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
5f7b6c1
into
cloudforet-io:feature-project-alert-manager
7 checks passed
skdud4659
added a commit
that referenced
this pull request
Jan 16, 2025
* feat: add CloudServiceAlertsTab component for viewing at cloudService (#5486) * feat(alert): add asset_id parameter to alert list interface - Introduced asset_id as a new parameter in the alert list interface. Signed-off-by: sulmo <sulmo@megazone.com> * feat: add CloudServiceAlertsTab component for viewing at cloudService - Introduced a new Vue component to manage cloud service alerts. - Implemented data fetching and filtering for alerts based on status and urgency. - Added functionality to export alert data to Excel. - Integrated custom field modal for table customization. Signed-off-by: sulmo <sulmo@megazone.com> * feat: add alerts tab for cloud service detail - Import `CloudServiceAlertsTab` component. - Add `alerts` tab conditionally based on alert manager version. - Update template to include the new alerts tab. Signed-off-by: sulmo <sulmo@megazone.com> * feat(language-pack): add translations for "TAB_ALERTS" - Added "TAB_ALERTS" concept node with translations in console-translation file - Updated English, Japanese, and Korean JSON files with "TAB_ALERTS" translation Signed-off-by: sulmo <sulmo@megazone.com> --------- Signed-off-by: sulmo <sulmo@megazone.com> * feat: fix bug of badge in double check table modal (#5484) Signed-off-by: 이승연 <sylee1274@mz.co.kr> * feat: apply mobile responsive design to the event rules page (#5524) * feat: apply mobile responsive design to the event rules page Signed-off-by: 이승연 <sylee1274@mz.co.kr> * feat: add necessary comment about `design system custom` Signed-off-by: 이승연 <sylee1274@mz.co.kr> --------- Signed-off-by: 이승연 <sylee1274@mz.co.kr> * feat: apply qa issue and update event rule (#5527) * fix: fixed bug Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * chore: remove total count section Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply protocol select dropdown at update modal Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: changed scope order Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply order drag at sidebar Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply feedback at condition form Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * chore: update translations Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * refactor: refactor action form Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply period at event rule card Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply mobile reactivity Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> --------- Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply match asset dropdown (#5530) * feat: add selected prop Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply asset type Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * chore: update translations Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> --------- Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply qa issue (#5531) * chore: changed service card style Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: fixed bug Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> --------- Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply mapping key (#5532) * feat: apply mapping key Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * fix: fixed label display bug at alert management table Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> --------- Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: add operator (#5533) Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: update mobile responsive design of event rules page (#5534) * feat: update mobile responsive design of event rules page Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr> * feat: add minor style code Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr> --------- Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr> * fix(reference-store): correct logic for selecting fetcher based on version (#5536) - Inverted the condition for determining the collector and region fetchers - Ensured correct API client is used based on alert manager version Signed-off-by: sulmo <sulmo@megazone.com> * chore: changed css (#5537) Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> --------- Signed-off-by: sulmo <sulmo@megazone.com> Signed-off-by: 이승연 <sylee1274@mz.co.kr> Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr> Co-authored-by: sulmo <sulmo@megazone.com> Co-authored-by: syeeeee <165753731+seungyeoneeee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ci, straightforward changes, etc.)Description (optional)
user & userGroup remove double check modal - bug about badge style
before update

after update

Things to Talk About (optional)