Skip to content

Conversation

@seungyeoneeee
Copy link
Contributor

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

user & userGroup remove double check modal - bug about badge style

  • before update
    image

  • after update
    image

Things to Talk About (optional)

Signed-off-by: 이승연 <sylee1274@mz.co.kr>
@vercel
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 1:50am
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 1:50am

Copy link
Member

@skdud4659 skdud4659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@seungyeoneeee seungyeoneeee merged commit 5f7b6c1 into cloudforet-io:feature-project-alert-manager Jan 14, 2025
7 checks passed
skdud4659 added a commit that referenced this pull request Jan 16, 2025
* feat: add CloudServiceAlertsTab component for viewing at cloudService (#5486)

* feat(alert): add asset_id parameter to alert list interface

- Introduced asset_id as a new parameter in the alert list interface.

Signed-off-by: sulmo <sulmo@megazone.com>

* feat: add CloudServiceAlertsTab component for viewing at cloudService

- Introduced a new Vue component to manage cloud service alerts.
- Implemented data fetching and filtering for alerts based on status and urgency.
- Added functionality to export alert data to Excel.
- Integrated custom field modal for table customization.

Signed-off-by: sulmo <sulmo@megazone.com>

* feat: add alerts tab for cloud service detail

- Import `CloudServiceAlertsTab` component.
- Add `alerts` tab conditionally based on alert manager version.
- Update template to include the new alerts tab.

Signed-off-by: sulmo <sulmo@megazone.com>

* feat(language-pack): add translations for "TAB_ALERTS"

- Added "TAB_ALERTS" concept node with translations in console-translation file
- Updated English, Japanese, and Korean JSON files with "TAB_ALERTS" translation

Signed-off-by: sulmo <sulmo@megazone.com>

---------

Signed-off-by: sulmo <sulmo@megazone.com>

* feat: fix bug of badge in double check table modal (#5484)

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* feat: apply mobile responsive design to the event rules page (#5524)

* feat: apply mobile responsive design to the event rules page

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* feat: add necessary comment about `design system custom`

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

---------

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* feat: apply qa issue and update event rule (#5527)

* fix: fixed bug

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: remove total count section

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply protocol select dropdown at update modal

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: changed scope order

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply order drag at sidebar

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply feedback at condition form

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: update translations

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* refactor: refactor action form

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply period at event rule card

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply mobile reactivity

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply match asset dropdown (#5530)

* feat: add selected prop

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply asset type

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: update translations

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply qa issue (#5531)

* chore: changed service card style

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: fixed bug

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply mapping key (#5532)

* feat: apply mapping key

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* fix: fixed label display bug at alert management table

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: add operator (#5533)

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: update mobile responsive design of event rules page (#5534)

* feat: update mobile responsive design of event rules page

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

* feat: add minor style code

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

---------

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

* fix(reference-store): correct logic for selecting fetcher based on version (#5536)

- Inverted the condition for determining the collector and region fetchers
- Ensured correct API client is used based on alert manager version

Signed-off-by: sulmo <sulmo@megazone.com>

* chore: changed css (#5537)

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: sulmo <sulmo@megazone.com>
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>
Co-authored-by: sulmo <sulmo@megazone.com>
Co-authored-by: syeeeee <165753731+seungyeoneeee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants