Skip to content

feat: apply alert manager (#5539)#5540

Merged
skdud4659 merged 1 commit intomasterfrom
develop
Jan 16, 2025
Merged

feat: apply alert manager (#5539)#5540
skdud4659 merged 1 commit intomasterfrom
develop

Conversation

@skdud4659
Copy link
Member


  • Inverted the condition for determining the collector and region fetchers
  • Ensured correct API client is used based on alert manager version

To Reviewers

  • Minor change, self-reviewed (style, chore, ci, test, docs)
  • Previously reviewed in feature branch, no further review needed
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

* ci: add check for PR author organization membership and assign them (#5521)

* chore: for ci test

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* ci: add check for PR author organization membership and assign them

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* ci: update pull request review labeler to handle reopened events

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* ci: enhance pull request review labeler to handle missing review state

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

---------

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* chore: ci test (#5522)

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* fix(reference-store): correct logic for selecting fetcher based on version (#5536)

- Inverted the condition for determining the collector and region fetchers
- Ensured correct API client is used based on alert manager version

Signed-off-by: sulmo <sulmo@megazone.com>

* chore: changed css (#5537)

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: Wanjin Noh <wanjin@megazone.com>
Signed-off-by: sulmo <sulmo@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Co-authored-by: WANJIN <wanjin@megazone.com>
Co-authored-by: sulmo <sulmo@megazone.com>
@vercel
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inventory-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 2:51am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 2:51am
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 2:51am

@skdud4659 skdud4659 added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jan 16, 2025
@github-actions
Copy link
Contributor

🎉 @sulmoJ and @kkdy21 have been randomly selected as the reviewers! Please review. 🙏

@github-actions github-actions bot requested review from kkdy21 and sulmoJ January 16, 2025 02:51
@github-actions github-actions bot added the pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. label Jan 16, 2025
@skdud4659 skdud4659 merged commit 9ac421b into master Jan 16, 2025
7 checks passed
@github-actions github-actions bot removed the pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pass/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant