feat: apply qa and additional requests #5552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
skdud4659
added
the
self_approved/review
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
skdud4659
merged commit 8c8be52
into
cloudforet-io:feature-project-alert-manager
8 checks passed
skdud4659
added a commit
that referenced
this pull request
Jan 20, 2025
* ci: add check for PR author organization membership and assign them (#5521) * chore: for ci test Signed-off-by: Wanjin Noh <wanjin@megazone.com> * ci: add check for PR author organization membership and assign them Signed-off-by: Wanjin Noh <wanjin@megazone.com> * ci: update pull request review labeler to handle reopened events Signed-off-by: Wanjin Noh <wanjin@megazone.com> * ci: enhance pull request review labeler to handle missing review state Signed-off-by: Wanjin Noh <wanjin@megazone.com> --------- Signed-off-by: Wanjin Noh <wanjin@megazone.com> * chore: ci test (#5522) Signed-off-by: Wanjin Noh <wanjin@megazone.com> * fix(reference-store): correct logic for selecting fetcher based on version (#5536) - Inverted the condition for determining the collector and region fetchers - Ensured correct API client is used based on alert manager version Signed-off-by: sulmo <sulmo@megazone.com> * chore: changed css (#5537) Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply qa and additional requests (#5552) * chore: changed icon color Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: create alert creation button at service page Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: update history error modal Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: create app reference store and apply app name at timeline Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply resource link at alert detail page Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply 'user group' text at member modal Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply raw data modal at webhook error tab Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * fix: fixed timeline bug Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply filter retention Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * chore: changed translations and style Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: changed create alert button position Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: fixed condition form bug and translate operator Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * chore: translations Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> --------- Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * fix: fixed qa bug (#5554) * fix: fixed minor bug (timeline) Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * fix: fixed qa bug Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> --------- Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> * feat: apply sort (#5555) Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> --------- Signed-off-by: Wanjin Noh <wanjin@megazone.com> Signed-off-by: sulmo <sulmo@megazone.com> Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com> Co-authored-by: WANJIN <wanjin@megazone.com> Co-authored-by: sulmo <sulmo@megazone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ci,test,docs)Description (optional)
SSIA
Things to Talk About (optional)