refactor: use VueQuery rather than SpaceConnector #5835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
|
@yuda110 is attempting to deploy a commit to the cloudforet Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 @seungyeoneeee and @WANZARGEN have been randomly selected as the reviewers! Please review. 🙏 |
piggggggggy
approved these changes
May 8, 2025
Comment on lines
11
to
16
| const { data, isLoading, error } = useScopedQuery({ | ||
| queryKey: costReportConfigQueryKey, | ||
| queryFn: async () => { | ||
| const res = await costReportConfigAPI.list(params.value); | ||
| return res.results?.[0] ?? null; | ||
| }, |
Member
There was a problem hiding this comment.
nitpick:
It is recommended that Query data be maintained in the original data format received from the server, which is the rule for consistency of cached data when the same data is requested from somewhere else with the same key of the same structure.
If data processing is required, please use useQuery's select option or calculate it outside.
Query 데이터는 서버로부터 받은 원본 데이터 형식을 유지하는 것을 권장합니다. 같은 데이터를 같은 구조의 키로 다른 곳에서 요청했을 때, 캐시된 데이터의 정합성을 위한 룰입니다.
데이터 가공이 필요하다면, useQuery의 select옵션을 이용하거나 외부에서 계산해주세요.
Comment on lines
+101
to
+108
| const { mutate: updateCostReportConfig } = useCostReportUpdateMutation({ | ||
| onSuccess: () => { | ||
| showSuccessMessage(i18n.t('BILLING.COST_MANAGEMENT.COST_REPORT.ALT_S_UPDATE_SETTINGS'), ''); | ||
| } catch (e) { | ||
| ErrorHandler.handleRequestError(e, i18n.t('BILLING.COST_MANAGEMENT.COST_REPORT.ALT_E_UPDATE_SETTINGS')); | ||
| } | ||
| }; | ||
| }, | ||
| onError: (error) => { | ||
| ErrorHandler.handleRequestError(error, i18n.t('BILLING.COST_MANAGEMENT.COST_REPORT.ALT_E_UPDATE_SETTINGS')); | ||
| }, | ||
| }); |
Member
There was a problem hiding this comment.
Suggestion: If you don't need to sync or disable the cache, I don't think you need to use mutation!
쿼리 캐시의 동기화 혹은 무효화가 필요하지 않다면, 굳이 mutation을 이용할 필요는 없을 것 같습니다!
Signed-off-by: yuda <yuda@megazone.com>
yuda110
merged commit 7e33118
into
cloudforet-io:feature-cost-report
7 of 9 checks passed
yuda110
added a commit
that referenced
this pull request
May 9, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 9, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 12, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 15, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 16, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 19, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 21, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 23, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 26, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 29, 2025
* feat: add vue query and mutation of `CostReport` Signed-off-by: yuda <yuda@megazone.com> * refactor: use VueQuery rather than SpaceConnector Signed-off-by: yuda <yuda@megazone.com> * fix: use `select` in `useCostReportConfigQuery` Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)