feat: add 'reissue' button #5862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
|
@yuda110 is attempting to deploy a commit to the cloudforet Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 @piggggggggy and @skdud4659 have been randomly selected as the reviewers! Please review. 🙏 |
yuda110
requested review from
Copilot
and removed request for
piggggggggy and
skdud4659
There was a problem hiding this comment.
Pull Request Overview
This PR adds a “Reissue” button to the upcoming cost report card, wiring it to a new API endpoint and providing success/error feedback, along with the necessary translation keys and API schema updates.
- Introduces
REISSUE_REPORT,ALT_S_REISSUE_REPORT, andALT_E_REISSUE_REPORTtranslation keys in JSON and Babel files. - Adds
runverb to the cost-report-config API schema and composable. - Implements a
Reissuebutton inCostReportUpcomingReportCard.vuewith a Vue Query mutation and success/error handling.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/language-pack/ko.json, ja.json, en.json | Added new translation keys for “Reissue” and alerts |
| packages/language-pack/console-translation-2.8.babel | Added new <concept_node> entries (no default_text) |
| apps/web/src/services/cost-explorer/components/CostReportUpcomingReportCard.vue | Render “Reissue” button and hook up mutation |
| apps/web/src/api-clients/cost-analysis/cost-report-config/schema/api-verbs/run.ts | Defined CostReportConfigRunParameters |
| apps/web/src/api-clients/cost-analysis/cost-report-config/composables/use-cost-report-config-api.ts | Exposed run in useCostReportConfigApi |
Comments suppressed due to low confidence (2)
apps/web/src/services/cost-explorer/components/CostReportUpcomingReportCard.vue:16
- [nitpick] The
languagesimport is no longer used in this component—consider removing it to clean up unused dependencies.
import { languages } from '@/store/user/constant';
apps/web/src/services/cost-explorer/components/CostReportUpcomingReportCard.vue:61
- There are no tests covering the new “Reissue” button or its mutation logic; consider adding unit or integration tests to verify API calls, query invalidation, and success/error notifications.
const handleReissueReport = async () => {
| }); | ||
|
|
||
| const { key: costReportConfigListQueryKey } = useServiceQueryKey('cost-analysis', 'cost-report-config', 'list'); | ||
| const { mutateAsync: reissueReport, isPending: reissueReportLoading } = useMutation({ |
There was a problem hiding this comment.
Vue Query's useMutation does not expose isPending; you should use isLoading (or isMutating) to track loading state so the button loading indicator works correctly.
Suggested change
| const { mutateAsync: reissueReport, isPending: reissueReportLoading } = useMutation({ | |
| const { mutateAsync: reissueReport, isMutating: reissueReportLoading } = useMutation({ |
| </translation> | ||
| </translations> | ||
| </concept_node> | ||
| <concept_node> |
There was a problem hiding this comment.
New <concept_node> entries lack <default_text> values — adding default text will give translators necessary context.
Signed-off-by: yuda <yuda@megazone.com>
piggggggggy
approved these changes
May 19, 2025
Member
piggggggggy
left a comment
piggggggggy
left a comment
There was a problem hiding this comment.
LGTM! I left a small comment!
| const actions = { | ||
| update: SpaceConnector.clientV2.costAnalysis.costReportConfig.update<CostReportConfigUpdateParameters, CostReportConfigModel>, | ||
| list: SpaceConnector.clientV2.costAnalysis.costReportConfig.list<CostReportConfigListParameters, ListResponse<CostReportConfigModel>>, | ||
| run: SpaceConnector.clientV2.costAnalysis.costReportConfig.run<CostReportConfigRunParameters, CostReportConfigModel>, |
Member
There was a problem hiding this comment.
nitpick: Is value returned by run verb CostReportConfigModel correct?
Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 19, 2025
* feat: add 'reissue' button Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> * chore: delete invalidating query cache Signed-off-by: yuda <yuda@megazone.com> * fix: set proper return value Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 21, 2025
* feat: add 'reissue' button Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> * chore: delete invalidating query cache Signed-off-by: yuda <yuda@megazone.com> * fix: set proper return value Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 23, 2025
* feat: add 'reissue' button Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> * chore: delete invalidating query cache Signed-off-by: yuda <yuda@megazone.com> * fix: set proper return value Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 26, 2025
* feat: add 'reissue' button Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> * chore: delete invalidating query cache Signed-off-by: yuda <yuda@megazone.com> * fix: set proper return value Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 29, 2025
* feat: add 'reissue' button Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> * chore: delete invalidating query cache Signed-off-by: yuda <yuda@megazone.com> * fix: set proper return value Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
SSIA
run
cost-report-config/runapi when clickreissuebutton