feat: set fields in adjustment form #5864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
|
@yuda110 is attempting to deploy a commit to the cloudforet Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 @seungyeoneeee has been randomly selected as the reviewer! Please review. 🙏 |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new "input-left" slot for the text-input component and extends the adjustments form to support provider selection and new adjustment types while updating corresponding translations.
- Added new slot configuration and rendering for "input-left" in text-input components and related stories.
- Updated translations and language pack entries for new fixed/percentage adjustment types.
- Enhanced the adjustments form with provider and adjustment dropdowns along with symbolic representations for amount fields.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/mirinae/src/controls/input/text-input/story-helper.ts | Added inputLeftSlot definition with documentation for the new slot. |
| packages/mirinae/src/controls/input/text-input/PTextInput.vue | Added slot rendering for input-left and updated style selectors. |
| packages/mirinae/src/controls/input/text-input/PTextInput.stories.ts | Updated story to showcase the new input-left slot functionality. |
| packages/language-pack/*.json & console-translation-2.8.babel | Added translation entries for new fixed and percentage adjustment types. |
| apps/web/src/services/cost-explorer/components/AdvancedSettingsAdjustmentsForm.vue | Enhanced the adjustments form with new provider and adjustment dropdowns and introduced symbolic display for amount fields. |
| description: 'Slot on the left of the input.', | ||
| table: { | ||
| type: { | ||
| summary: null, |
There was a problem hiding this comment.
[nitpick] Consider providing a brief, descriptive summary for the inputLeftSlot type instead of null to improve component documentation.
| width="1rem" | ||
| height="1rem" | ||
| /> | ||
| <p-i v-if="dropdownItem && dropdownItem.icon" |
There was a problem hiding this comment.
[nitpick] If 'dropdownItem.icon' is intended for display, ensure that provider menu item objects include an 'icon' property or consider removing this conditional block to avoid confusion.
yuda110
added a commit
that referenced
this pull request
May 21, 2025
* feat: add `input-left` slot to PTextInput Signed-off-by: yuda <yuda@megazone.com> * feat: set provider, adjustment select dropdown Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 23, 2025
* feat: add `input-left` slot to PTextInput Signed-off-by: yuda <yuda@megazone.com> * feat: set provider, adjustment select dropdown Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 26, 2025
* feat: add `input-left` slot to PTextInput Signed-off-by: yuda <yuda@megazone.com> * feat: set provider, adjustment select dropdown Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 29, 2025
* feat: add `input-left` slot to PTextInput Signed-off-by: yuda <yuda@megazone.com> * feat: set provider, adjustment select dropdown Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
feat: add
input-leftslot to PTextInputfeat: set provider, adjustment select dropdown
