feat: add column at service account attached general accounts table #5873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
@skdud4659 is attempting to deploy a commit to the cloudforet Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 @yuda110 has been randomly selected as the reviewer! Please review. 🙏 |
There was a problem hiding this comment.
Pull Request Overview
Adds a new “Last Synced” column to the ServiceAccountAttachedGeneralAccounts table and provides a formatting slot for its values.
- Defined the
last_synced_atcolumn in the reactive state - Implemented a
<template>slot to formatlast_synced_atwith timezone-awaredayjs
Comments suppressed due to low confidence (1)
apps/web/src/services/service-account/components/ServiceAccountAttachedGeneralAccounts.vue:115
- Add or update unit/component tests to cover the new
last_synced_atcolumn rendering, including correct date formatting and the fallback'-'for null values.
{ name: 'last_synced_at', label: 'Last Synced', sortable: false },
skdud4659
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
SSIA
Things to Talk About (optional)