fix: fix promise bug when save adjustments #5875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
@yuda110 is attempting to deploy a commit to the cloudforet Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 @seungyeoneeee has been randomly selected as the reviewer! Please review. 🙏 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a promise bug when saving adjustments by updating API sort parameters and refining update logic.
- Changed sort order from "created_at" (ascending) to "order" (descending) in the adjustment policy query.
- Enhanced update functions in the AdvancedSettings overlay by checking for differences before updating and using Promise.all for concurrency.
- Updated the adjustment iteration logic and success messaging to leverage internationalized text and a helper function.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/src/services/cost-explorer/composables/queries/use-report-adjustment-policy-query.ts | Updates the API helper sort field and direction to sort by "order" descending |
| apps/web/src/services/cost-explorer/components/AdvancedSettingsSetAdjustmentsOverlay.vue | Refactors update methods with pre-checks for difference, replaces forEach with Promise.all for concurrent operations, and revises the adjustment iteration logic |
Comments suppressed due to low confidence (1)
apps/web/src/services/cost-explorer/components/AdvancedSettingsSetAdjustmentsOverlay.vue:227
- Mapping over formPolicies to process adjustments may inadvertently omit adjustments that do not have a corresponding policy. Consider iterating directly over formAdjustments or ensuring that all adjustments are captured.
await Promise.all(formPolicies.value.map(async (policy) => {
yuda110
added a commit
that referenced
this pull request
May 23, 2025
* fix: fix promise bug when save adjustments Signed-off-by: yuda <yuda@megazone.com> * chore: sort with order Signed-off-by: yuda <yuda@megazone.com> * chore: do not raise api when there's no change Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 26, 2025
* fix: fix promise bug when save adjustments Signed-off-by: yuda <yuda@megazone.com> * chore: sort with order Signed-off-by: yuda <yuda@megazone.com> * chore: do not raise api when there's no change Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
yuda110
added a commit
that referenced
this pull request
May 29, 2025
* fix: fix promise bug when save adjustments Signed-off-by: yuda <yuda@megazone.com> * chore: sort with order Signed-off-by: yuda <yuda@megazone.com> * chore: do not raise api when there's no change Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)