fix: ensure order is preserved in Promise.all of adjustments#5920
Merged
yuda110 merged 1 commit intocloudforet-io:developfrom Jun 4, 2025
Merged
fix: ensure order is preserved in Promise.all of adjustments#5920yuda110 merged 1 commit intocloudforet-io:developfrom
yuda110 merged 1 commit intocloudforet-io:developfrom
Conversation
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
@yuda110 is attempting to deploy a commit to the cloudforet Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 @seungyeoneeee has been randomly selected as the reviewer! Please review. 🙏 |
There was a problem hiding this comment.
Pull Request Overview
This PR replaces concurrent Promise.all execution with sequential promise chaining to ensure that order is preserved during adjustment policy and adjustment processing.
- Processes adjustment policies sequentially by replacing a map/Promise.all pattern with an async reduce chain.
- Updates adjustment processing similarly to enforce sequential execution.
Comments suppressed due to low confidence (1)
apps/web/src/services/cost-explorer/components/AdvancedSettingsSetAdjustmentsOverlay.vue:235
- The sequential processing of adjustments via reduce enforces order, but it may be less performant than parallel execution if order is not critical. Please confirm that preserving order is a necessary requirement.
await formPolicies.value.reduce(async (promise, policy) => {
Comment on lines
+225
to
+245
| await formPolicies.value.reduce(async (promise, policy, idx) => { | ||
| await promise; | ||
| if (policy.id.startsWith('rap-')) { | ||
| return updateAdjustmentPolicy(policy, idx); | ||
| } | ||
| return createAdjustmentPolicy(policy, idx); | ||
| }); | ||
| await Promise.all(policyPromises); | ||
| }, Promise.resolve()); | ||
|
|
||
| // CUD Adjustment | ||
| await deleteAdjustment(deletedPolicyIds); | ||
| const adjustmentPromises = formPolicies.value.flatMap(async (policy) => { | ||
| await formPolicies.value.reduce(async (promise, policy) => { | ||
| await promise; | ||
| const adjustments = formAdjustments.value.filter((adjustment) => adjustment.policyId === policy.id); | ||
| return adjustments.map(async (adjustment, idx) => { | ||
| return adjustments.reduce(async (adjPromise, adjustment, idx) => { | ||
| await adjPromise; | ||
| if (adjustment.id.startsWith('ra-')) { | ||
| return updateAdjustment(adjustment, idx); | ||
| } | ||
| return createAdjustment(adjustment, idx); | ||
| }); | ||
| }); | ||
| const resolvedAdjustments = await Promise.all(adjustmentPromises); | ||
| await Promise.all(resolvedAdjustments.flat()); | ||
| }, Promise.resolve()); | ||
| }, Promise.resolve()); |
There was a problem hiding this comment.
Switching to sequential execution ensures order preservation, but may introduce performance overhead with large policy arrays. Consider documenting the performance trade-off if sequential processing is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)