Fix missing tag in docker-bbl-deployment registry-image resource#680
Merged
Conversation
Replace deprecated docker-image resource type with registry-image and concourse/oci-build-task for building and pushing Docker images. The docker-image resource forces DOCKER_BUILDKIT=0 (legacy builder) which is incompatible with Docker 28+. - Switch docker-bbl-deployment and cf-deployment-concourse-tasks-bbl-dev resources to registry-image type - Add oci-build-task build steps before each registry-image put - Remove deprecated email field from resource source config
registry-image resource requires an explicit tag in source or version in put params, unlike docker-image which defaulted to 'latest'. Add tag: latest to match previous behavior.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request adds an explicit Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Actionable comments posted: 0 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
aramprice
approved these changes
May 28, 2026
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tag: latestto thedocker-bbl-deploymentregistry-image resource source configRoot Cause
The
registry-imageresource requires an explicit tag — eithertag:insourceorversion:inputparams. Unlike the olddocker-imageresource which silently defaulted tolatest,registry-imageerrors with:This caused build #62 to fail after the migration in #679.
Fix
Add
tag: latestto the resource source, matching the previous implicit behavior.