Fix linting errors in improve_help_scp branch#698
Merged
rkoster merged 1 commit intocloudfoundry:improve_help_scpfrom Oct 10, 2025
Merged
Fix linting errors in improve_help_scp branch#698rkoster merged 1 commit intocloudfoundry:improve_help_scpfrom
rkoster merged 1 commit intocloudfoundry:improve_help_scpfrom
Conversation
Replace unescaped backticks with single quotes in the struct tag description to fix Go parser errors. Backticks within backtick-delimited struct tags cause syntax errors. Changes: - Replace `instance-group/id` with (instance-group/id) - Replace `bosh scp ...` with 'bosh scp ...' Fixes linting errors identified in code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes linting errors in the
improve_help_scpbranch to allow PR #693 to be merged.Problem
The
improve_help_scpbranch incloudfoundry/bosh-clicontains unescaped backticks within a backtick-delimited Go struct tag incmd/opts/opts.goline 1022. This causes Go parser errors that prevent the code from passing linting checks, blocking PR #693 from being merged.Solution
This PR adds a single commit that fixes the linting errors by replacing backticks with appropriate alternatives, while preserving all the improved help text:
`instance-group/id`→(instance-group/id)`bosh scp ...`→'bosh scp ...'Changes
Commit:
728230ae5- "fix: resolve linting errors in struct tag for bosh scp help"File:
cmd/opts/opts.go(line 1022)Before:
After:
File:
cmd/opts/opts_test.goUpdated test to use
ContainSubstringinstead ofEqualto accommodate the longer description.Impact
Once this PR is merged into the
improve_help_scpbranch:bosh scp -h#693 can be merged into mainTesting
ContainSubstringmatcherRelated
bosh scp -h#693