Merged
Conversation
|
|
- http tests were relying on a 10ms timeout for connect and tls handshake. On slow enough machines this was causing flaky failures. Changed to a 10 second timeout by default, with the option for tests to use a client with a 1ms timeout if they are testing failure cases. - asyc logging tests were expecting to finish within 10x the theoretical minimum time, which was good enough 999 out of 1000 times. 100x the theoretical minimum time seems to be good enough 1000 out of 1000 times.
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http tests were relying on a 10ms timeout for connect and tls handshake. On slow enough machines this was causing flaky failures. Changed to a 10 second timeout by default, with the option for tests to use a client with a 1ms timeout if they are testing failure cases.
asyc logging tests were expecting to finish within 10x the theoretical minimum time, which was good enough 999 out of 1000 times. 100x the theoretical minimum time seems to be good enough 1000 out of 1000 times.