Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
A while ago we added signed url support for swift blobstore to the S3cli.
With that we introduced two new parameters
swift_auth_accountandswift_temp_url_keyinto the S3cli.With this PR the director now forwards the parameters to the S3cli if they are set in the deployment manifest.
Please provide contextual information.
clientpackage bosh-s3cli#38What tests have you run against this PR?
we tested the integration with s3cli and ran the required unit tests
How should this change be described in bosh release notes?
Add support of signed for s3 compatible swift blobstores
Does this PR introduce a breaking change?
nope
Tag your pair, your PM, and/or team!
@anshrupani, @a-hassanin