Fix missing instance metrics_dir method#2679
Merged
aramprice merged 2 commits intocloudfoundry:mainfrom Feb 26, 2026
Merged
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
|
thank you! |
aramprice
approved these changes
Feb 26, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
Adds the missing instance method that was missed in #2654.
Please provide contextual information.
The
metrics_dirwas only added as a class method, but it was called as an instance method.See #2678 for more details.
What tests have you run against this PR?
Unit tests.
Tested with the change and the director starts okay with metrics_server enabled.
How should this change be described in bosh release notes?
Fixes a bug that was created with #2654 by adding the missing
metrics_dirinstance method.Does this PR introduce a breaking change?
Fixes #2678