Skip to content

Fix: update integration sandbox manifest generation#2721

Merged
aramprice merged 1 commit intomainfrom
fix-integration-sandbox-manifest-generation
Apr 29, 2026
Merged

Fix: update integration sandbox manifest generation#2721
aramprice merged 1 commit intomainfrom
fix-integration-sandbox-manifest-generation

Conversation

@aramprice
Copy link
Copy Markdown
Member

Manifest properties for Health Monitor changed in 61bab34c69 resulting in integration specs failing:

./spec/integration/config_server/config_server_links_spec.rb:417
./spec/integration/config_server/config_server_spec.rb:380
./spec/integration/health_monitor/hm_stateless_spec.rb:96
./spec/integration/uaa/login_spec.rb:128

since the integration sandbox test tooling does not use the standard job/.../templates/ content.

This commit updates the sanbox internal templates to use the new configuration params (ca_cert => director_ca_cert).

Manifest properties for Health Monitor changed in `61bab34c69`
resulting in integration specs failing:
```
./spec/integration/config_server/config_server_links_spec.rb:417
./spec/integration/config_server/config_server_spec.rb:380
./spec/integration/health_monitor/hm_stateless_spec.rb:96
./spec/integration/uaa/login_spec.rb:128
```

since the integration sandbox test tooling does not use the standard
`job/.../templates/` content.

This commit updates the sanbox internal templates to use the new
configuration params (`ca_cert` => `director_ca_cert`).
Copilot AI review requested due to automatic review settings April 29, 2026 21:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 03c9ec1d-2af3-4838-8d58-d3caea7da3e7

📥 Commits

Reviewing files that changed from the base of the PR and between 61bab34 and 070bae2.

📒 Files selected for processing (2)
  • src/spec/assets/sandbox/health_monitor.yml.erb
  • src/spec/assets/sandbox/health_monitor_with_json_logging.yml.erb

Walkthrough

Two health monitor configuration template files are updated to rename the director TLS certificate field from ca_cert to director_ca_cert. The changes occur in health_monitor.yml.erb and health_monitor_with_json_logging.yml.erb. The certificate path value source remains unchanged in both files. This is a straightforward field renaming operation with minimal code impact.

Suggested reviewers

  • ragaskar
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides context about why changes were needed (manifest property changes breaking integration specs) and what was fixed, but is missing several required template sections. Add missing sections: contextual links/references, comprehensive test results, release notes description, breaking change assessment, and team tags as specified in the template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating integration sandbox manifest generation in response to Health Monitor configuration changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-integration-sandbox-manifest-generation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@ragaskar ragaskar requested review from ragaskar and removed request for Copilot April 29, 2026 21:27
@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Apr 29, 2026
@aramprice aramprice merged commit f7e7e73 into main Apr 29, 2026
26 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Apr 29, 2026
@aramprice aramprice deleted the fix-integration-sandbox-manifest-generation branch April 29, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants