Skip to content

CI: fix build-docker-args#2725

Merged
aramprice merged 1 commit intomainfrom
ci-fix-docker-build
May 4, 2026
Merged

CI: fix build-docker-args#2725
aramprice merged 1 commit intomainfrom
ci-fix-docker-build

Conversation

@aramprice
Copy link
Copy Markdown
Member

Fixes:

Failed to parse build_args_file (docker-build-args/docker-build-args.json)

^ https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-director/jobs/build-integration/builds/679#L69e7592c:9

Fixes:
```
Failed to parse build_args_file (docker-build-args/docker-build-args.json)
```
^ https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-director/jobs/build-integration/builds/679#L69e7592c:9
Copilot AI review requested due to automatic review settings May 4, 2026 21:41
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 674f3506-e1b8-4895-a580-9c796110ae62

📥 Commits

Reviewing files that changed from the base of the PR and between 44bd70a and 11bded5.

📒 Files selected for processing (1)
  • ci/dockerfiles/integration/build-docker-args.sh

Walkthrough

The change modifies the script ci/dockerfiles/integration/build-docker-args.sh to use a stricter pattern when selecting GitHub release assets for golangci-lint. The jq match() pattern was updated to anchor the filename to end with -linux-amd64.tar.gz$, ensuring the pattern matches only files ending with that specific suffix rather than any string containing it. This is a single line change with no modifications to other logic or outputs.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete, missing most required sections from the template including contextual information, test results, release notes guidance, breaking change notification, and team tags. Complete the description by filling in all required template sections: contextual links, tests run, bosh release notes, breaking change status, and team tags.
Title check ❓ Inconclusive The title 'CI: fix build-docker-args' is vague and generic, using non-specific terms like 'fix' without clearly conveying what the actual change is or what problem it solves. Provide a more descriptive title that explains the specific issue fixed, such as 'CI: fix golangci-lint asset selection in build-docker-args' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-fix-docker-build

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the CI task that generates Docker build arguments by ensuring the golangci-lint download URL selection does not accidentally match non-tarball assets (e.g., checksum/signature files), which can result in an invalid/multi-line JSON build-args file.

Changes:

  • Anchor the golangci-lint asset-name regex with $ so only the actual ...linux-amd64.tar.gz asset is selected.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aramprice aramprice requested review from a team, Alphasite and mariash and removed request for a team May 4, 2026 21:44
@aramprice aramprice merged commit 29b4084 into main May 4, 2026
26 checks passed
@aramprice aramprice deleted the ci-fix-docker-build branch May 4, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants