Skip to content

CI: Interpolate DNS ops files from repo root#2736

Merged
selzoc merged 1 commit into
mainfrom
ops-files-are-relative-to-repo-root
May 14, 2026
Merged

CI: Interpolate DNS ops files from repo root#2736
selzoc merged 1 commit into
mainfrom
ops-files-are-relative-to-repo-root

Conversation

@selzoc
Copy link
Copy Markdown
Member

@selzoc selzoc commented May 14, 2026

No description provided.

ai-assisted=yes
[TNZ-88995]

Co-authored-by: Matthew Kocher <matthew.kocher@broadcom.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9d0dd6ee-9831-403f-9272-e20ded71a504

📥 Commits

Reviewing files that changed from the base of the PR and between bdc8b89 and fda8541.

📒 Files selected for processing (1)
  • ci/shared/brats/test-acceptance.sh

Walkthrough

The DNS manifest integration step in the test acceptance script now wraps the bosh int invocation with pushd/popd to execute from REPO_PARENT. This change ensures that relative ops-file paths provided through BRATS_DNS_MANIFEST_OPS_FILES resolve correctly against the Concourse build root. The generated manifest is written to a temporary location and then copied back to DNS_MANIFEST as before.

Suggested reviewers

  • mkocher
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ops-files-are-relative-to-repo-root

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@selzoc selzoc merged commit 2e8982c into main May 14, 2026
20 of 21 checks passed
@selzoc selzoc deleted the ops-files-are-relative-to-repo-root branch May 14, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants