CI: Properly namespace directors#2742
Merged
Merged
Conversation
The cleanup-leftover-environemnts task in the bats job was unintentionally targeting directors from other jobs that run concurrently, leading to failures of those jobs or the cleanup. This happened because each job shared the same deploy-director script, which named the director "bats-director", and the leftover filter used was just "bats". Instead, use the name of the environment to name the director. As an additional upside, now all the other *-cleanup-leftovers jobs will correctly clean up their own directors as well. ai-assisted=yes [TNZ-88995]
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe deploy-director script now dynamically derives the director name from the environment metadata's network field using jq, defaulting to 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Example: https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-director/jobs/bats/builds/519 |
ystros
approved these changes
Jun 4, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Member
Author
|
It also unintentionally deleted bats vms from the stemcell pipeline, working on a fix for that as well: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup-leftover-environemnts task in the bats job was unintentionally targeting directors from other jobs that run concurrently, leading to failures of those jobs or the cleanup.
This happened because each job shared the same deploy-director script, which named the director "bats-director", and the leftover filter used was just "bats". Instead, use the name of the environment to name the director.
As an additional upside, now all the other *-cleanup-leftovers jobs will correctly clean up their own directors as well.