add cpi log directory to allowed volumes, refactor bpm.yml

[mkocher]

The warden CPI was failing because it could not write logs. Fix should work for all CPIs.

Also cleaned up some duplication in bpm.yml.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6a455279-20db-4432-825b-44fd78d2ea4f

📥 Commits

Reviewing files that changed from the base of the PR and between 9bfb104 and 0cc823c.

📒 Files selected for processing (1)

• jobs/director/templates/bpm.yml

---

Walkthrough

This change refactors jobs/director/templates/bpm.yml to compute CPI volumes and worker environment variables through shared template variables rather than per-worker inline logic. New variables worker_cpi_volumes and worker_thread_env are introduced. Both regular worker processes and dynamic disks worker processes now derive their "env" by merging worker_thread_env with a "QUEUE" value, and their "unsafe" setting from worker_cpi_volumes when non-empty, replacing the previous individual construction logic for each worker type.

Changes

Related PRs: None found

Suggested labels: director, bpm, refactor

Suggested reviewers: cloudfoundry/bosh-director-maintainers

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	It explains the fix and refactor, but omits required template sections like context links, tests, release notes, breaking change impact, and tags.	Fill out the template with contextual links, tests run, release-note wording, breaking-change impact, and team/pair tags.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: allowing the CPI log directory and refactoring bpm.yml.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bpm-worker-follow-up

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@jobs/director/templates/bpm.yml`:
- Around line 66-68: The worker loop still duplicates the construction of the
"env" and "unsafe" fields in bpm.yml, so extract that shared logic into a small
helper and reuse it from both worker loops. Use the existing worker hash
assembly around the worker["env"] and worker["unsafe"] assignments to centralize
the merge of worker_thread_env with QUEUE and the conditional
unrestricted_volumes handling, keeping both loops consistent and reducing
duplication.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 490049f7-848a-4bf9-a4f0-1c7ea287ee04

📥 Commits

Reviewing files that changed from the base of the PR and between 8d29a2b and 9bfb104.

📒 Files selected for processing (1)

• jobs/director/templates/bpm.yml