issue in ApplicationManifestUtils.write method (partial solution only given)

[parasuram-tanguturu]

ApplicationManifestUtils.write(OutputStream out, List<ApplicationManifest> applicationManifests) 1.giving manifest in which memory does not have any unit of measurement.like M, MB, G, or GB.
2.path in output manifest is AbsolutePath .(expected is whatever available in old manifest).

i used the following manifest to ApplicationManifestUtils.read:

---
applications:
- name: apicomp
  memory: 1024M
  buildpack: java_buildpack
  instances: 1
  path: /Backend/demo-0.0.1-SNAPSHOT.jar
  random-route: true 
  services:
    - autodeployinst  
- name: uicomp
  memory: 1024M
  buildpack: staticfile_buildpack
  instances: 1
  path: /UI_Codes/dist/
  random-route: true 

then used
ApplicationManifestUtils.write to modify appName and got manifest output as:

---
applications:
- buildpack: java_buildpack
  instances: 1
  memory: 1024
  name: apicomp-green
  path: C:\Backend\demo-0.0.1-SNAPSHOT.jar
  random-route: true
  services:
  - autodeployinst
- buildpack: staticfile_buildpack
  instances: 1
  memory: 1024
  name: uicomp-green
  path: C:\UI_Codes\dist
  random-route: true

[nebhale]

In a manifest, memory without a suffix is interpreted as megabytes. This means that 1024M and 1024 are equivalent to the API. In fact, under the hood the REST API that backs creation of applications only accepts an integer of megabytes.

ApplicationManifestUtils does not aim to preserve the input values and ordering when outputting, instead writing a functionally equivalent manifest.

[parasuram-tanguturu]

but without any measurement tries to push app ,it is giving following error.

Byte quantity must be a positive integer with a unit of measurement like M, MB, G, or GB
FAILED

[nebhale]

I don't see that string in the Java Client. What's the stack trace for the error?

[parasuram-tanguturu]

The above error I got from CLI .
When I tried to push app
Which has memory without any Measurement I.e. by using 2nd manifest.

from CLI:
https://gowalker.org/github.com/cloudfoundry/cli/util/manifest
Memory types.NullByteSizeInMb
type NullByteSizeInMb struct {
IsSet bool

// Value is a size in MB
Value uint64

}

[parasuram-tanguturu]

Use case is:

Read a manifest ,
Create new manifest from it by modifying required parameters like appname..

[nebhale]

Yeah, this definitely a bug. While the underlying implementations are all doing the right thing with an integer of megabytes, the spec clearly states that a letter must be present. @twoseat to fix this I think you’ll need to write a custom serializer for this that appends an M after the number is written.

[parasuram-tanguturu]

2.path in output manifest is AbsolutePath .(expected is whatever available in old manifest).
In input manifest:
'''path: /Backend/demo-0.0.1-SNAPSHOT.jar'''
In output manifest:
'''path: C:\Backend\demo-0.0.1-SNAPSHOT.jar'''