Skip to content

Conversation

@checketts
Copy link
Contributor

@checketts checketts commented Jan 29, 2020

Fixes #1027 and contributes to #946

I'm new to this library so I've create the request/response and matching tests.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 29, 2020

CLA Check
The committers are authorized under a signed CLA.

@checketts
Copy link
Contributor Author

I submitted the CLA

…nnotations)

Add tests for the update of metadata for orgs and spaces
@nebhale nebhale requested a review from twoseat March 23, 2020 17:16
@twoseat
Copy link
Contributor

twoseat commented Mar 26, 2020

Hi @checketts I've working on the code now and aside from some formatting etc. all looks good. Unfortunately it kills our integration test platform (because our test cleanup doesn't yet have a way to delete the metadata your tests quite rightly create). But it is in progress!

@checketts
Copy link
Contributor Author

Thanks for the update!

Anything I can do to help with the integration tests? Or is it breaking un-related integration tests?

@twoseat
Copy link
Contributor

twoseat commented Mar 26, 2020

The problem, which I imagine you may find yourself hitting at some point, is that neither the v2 nor v3 delete-space endpoints currently support deleting spaces with associated metadata. And as our integration test suite cleans up everything after each run that's a problem! I'm going to temporarily fix it by cleaning the metadata first until space deletion is properly supported.

Let me know if you think I'm wrong!

@twoseat twoseat closed this in 429ac57 Mar 27, 2020
@twoseat twoseat added this to the 3.23.0.RELEASE milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Metadata to an Org in PCF

2 participants