Skip to content

Add application ports when updating applications #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add application ports when updating applications #989

wants to merge 1 commit into from

Conversation

@GFriedrich
Copy link
Contributor

@GFriedrich GFriedrich commented Aug 14, 2019 •
edited
Loading

[resolves #975]

@cfdreddbot
Copy link

✅ Hey GFriedrich! The commit authors and yourself have already signed the CLA.

@twoseat twoseat closed this in 5cd4b61 Sep 10, 2019
@twoseat
Copy link
Contributor

twoseat commented Sep 10, 2019

Reopened after discussion on planned CAPI changes

@twoseat twoseat reopened this Sep 10, 2019
@cfdreddbot
Copy link

✅ Hey GFriedrich! The commit authors and yourself have already signed the CLA.

@GFriedrich GFriedrich changed the title Add application ports to application manifest and... Add application ports when updating applications Sep 10, 2019
@GFriedrich
Copy link
Contributor Author

GFriedrich commented Sep 10, 2019 •
edited
Loading

@twoseat reduced the PR to add the app ports only to the update of applications
Issue #975 has been updated accordingly.

EDIT: And I've fixed the typo in the JavaDoc that you've fixed before (also on the place where I've copied the original description from).

@twoseat twoseat added this to the 3.16.0.RELEASE milestone Oct 1, 2019
@twoseat twoseat closed this Oct 1, 2019
@twoseat twoseat modified the milestones: 3.16.0.RELEASE, 3.18.0.RELEASE Oct 1, 2019
@twoseat twoseat reopened this Oct 1, 2019
@cfdreddbot
Copy link

✅ Hey GFriedrich! The commit authors and yourself have already signed the CLA.

@twoseat twoseat modified the milestones: 3.20.0.RELEASE, 3.21.0.RELEASE Jan 7, 2020
@twoseat twoseat removed this from the 3.21.0.RELEASE milestone Feb 18, 2020
@twoseat twoseat closed this in fde472f Apr 20, 2020
@twoseat twoseat self-assigned this Apr 20, 2020
@twoseat twoseat added this to the 3.23.0.RELEASE milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@twoseat twoseat

Labels

None yet

Projects

None yet

Milestone

3.23.0.RELEASE

Development

Successfully merging this pull request may close these issues.

Support "ports" application attribute via update

3 participants

@GFriedrich @cfdreddbot @twoseat