Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

Conversation

@fbonelle
Copy link
Contributor

@fbonelle fbonelle commented Apr 8, 2016

For our migration from v25 to v26, we had difficulties with deployment name hard coded. This patch adds the ability to set a personalized deployment name. The property property_overrides.deployment_name does not have to be defined (in this case, it's like the old behaviour).

@cfdreddbot
Copy link

Hey fbonelle!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/117225385.

@mfine30
Copy link
Contributor

mfine30 commented Apr 11, 2016

Hey @fbonelle,

This looks like a useful change for anyone who does not want to use the hardcoded deployment name and still use the manifest generation scripts included in the repo.

One thing that we would like to see in this commit before we merge it is the corresponding update to the manifest-generation/examples/property-overrides.yml file so that contributors and users of the release understand how to modify that property, similar to property_overrides.host.

Thanks,
Morgan
CF Core Services

Add property_overrides.deployment_name with some explanations
@fbonelle
Copy link
Contributor Author

Hi,
I have done what you asked for.
Regards

@menicosia
Copy link
Contributor

Hi @fbonelle,

Thanks! I'll prioritize this for the team to try to pull into the next release. You can follow the story's progress in our backlog, hopefully this will land in cf-mysql v27.

Marco Nicosia
Product Manager
Pivotal Software, Inc.

@aaronshurley aaronshurley merged commit f2edfcf into cloudfoundry:develop Apr 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants