This repository was archived by the owner on Sep 21, 2022. It is now read-only.
Added several acceptance_tests properties to templates. #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey antonsoroko! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Collaborator
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/118641279. |
Contributor
|
Hi @antonsoroko, Thanks for the contribution. I'm a little confused by the intention of this though. These values are indeed needed by the acceptance-tests job, but they are already readable in the spec file from different properties: https://github.com/cloudfoundry/cf-mysql-release/blob/develop/jobs/acceptance-tests/spec#L12-L20. The current properties are namespaced inside of Thanks, |
Contributor
Author
|
Hi @mfine30. Thank you for correction. |
cppforlife
pushed a commit
to cppforlife/cf-mysql-release
that referenced
this pull request
Dec 21, 2016
…thub.com/onsi/gomega
Bump cloudfoundry-incubator/galera-healthcheck:
Lyle Franklin:
Added mysqld binary location to config object instead of hardcoding it in sequence_number.go ( Travis Unknown )
Ben Calegari:
Alias /galera_status to / to maintain backwards compatability ( Travis Unknown )
Update /sequence_number to function even if DB is down ( Travis Unknown )
Change sequence_number Check() to private ( Travis Unknown )
Test galera binary ( Travis Unknown )
Move http response responsibility to endpoint objects ( Travis Unknown )
Push flag parsing logic into config package ( Travis Unknown )
Remove integration test suite ( Travis Unknown )
Bump :
Onsi Fakhouri:
Merge pull request cloudfoundry#112 from robdimsdale/master
Merge pull request cloudfoundry#113 from cf-guardian/master
update changelog: mention WithTransform and boolean matchers
pull oracle matcher into its own package
Merge pull request cloudfoundry#108 from jim-slattery-rs/composition
Merge pull request cloudfoundry#111 from sykesm/verify-proto
Merge pull request cloudfoundry#105 from sykesm/verify-form
add 1.5 to travis
Merge pull request cloudfoundry#103 from rosenhouse/occurred
ghttp server can take an io.Writer
ghttp handles failures and panics in handlers
Merge pull request cloudfoundry#98 from matt-royal/respond-with-json-sets-content-type
tell travis to use the latest golang
explain why gomega refuses to compare <nil> to <nil>
Merge pull request cloudfoundry#96 from craigfurman/HaveOccurredMatcher-nil-check-consistency
Merge pull request cloudfoundry#95 from jfmyers9/fix-respond-with-ptr
Merge pull request cloudfoundry#93 from james-lawrence/directory-matcher
Merge pull request cloudfoundry#91 from james-lawrence/file-based-matchers
Merge pull request cloudfoundry#89 from alext/improve_succeed_output
Merge pull request cloudfoundry#83 from hobeone/patch-1
ContainElement no longer bails if a passed-in matcher errors
session.Wait now emits the correct line number when failures occur
Zhou Yu:
Reformat
Rob Dimsdale:
Add VerifyBody method.
Matthew Sykes:
Add VerifyProtoRepresenting and RespondWithProto
Add matchers to verify form data
jim-slattery-rs:
make Or() support MatchMayChangeInTheFuture() - simplify tests by using empty And() or Or() instead of Receive() with a closed channel
make And() propagate MatchMayChangeInTheFuture() - considers both Match() cases and considers the appropriate matcher(s) in making decision - also added a comment to WithTransform.MatchMayChangeInTheFuture(), as it will not have correct behavior with non-deterministic transformer
make WithTransform() propagate MatchMayChangeInTheFuture() from wrapped matcher
make Not() propagate MatchMayChangeInTheFuture() from wrapped matcher
add SatisfyAll() and SatisfyAny() as aliases for And() and Or(), respectively
WithTransform() supports transform function with explicit types
Added Add, Or, Not, WithTransform matchers, for composability. - Allows matchers to be composed into complex expressions that work even with the Eventually() assertion. - Also makes it easy to create new matchers -- can often write a function that composes a new matcher out of existing ones.
Brian Cunnie:
Standardize spelling: occured --> occurred
Luan Santos and Matt Royal:
Allow user to explicitly set a Content-Type header on ghttp JSON handlers
Set Content-Type to application/json in RespondWithJSON* methods
Craig Furman:
Negative assertions on nil pointers to types that conform to error interface should not panic
James Myers:
Fix RespondWithJSONEncodedPtr
James Lawrence:
directory matcher string fixes
file based matchers
Alex Tomlins:
Improve Succeed() failure message.
Alex Suraci:
query params match irregardless of order
Daniel Hobe:
Return prettyprinted JSON strings for errors.
Signed-off-by: Aditya Anchuri <aanchuri@pivotal.io>
[#106993650]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added admin_user/admin_password/api/app_domains properties of acceptance_tests to templates.