This repository was archived by the owner on Sep 21, 2022. It is now read-only.
Resolve package name, job name, and port conflicts #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#109664588] Signed-off-by: Mark DeLillo <mdelillo@pivotal.io>
Signed-off-by: Mark DeLillo <mdelillo@pivotal.io>
Signed-off-by: Keaty Gross <kgross@pivotal.io>
[#109572230] Signed-off-by: Mark DeLillo <mdelillo@pivotal.io>
|
Hey keaty! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
Collaborator
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/113088085. |
Contributor
|
Hey Keaty, Sorry for the delay in getting to this, we've had a hectic week here. We just pulled it into the backlog and will take a look next week. Best, |
Contributor
|
Hi Keaty, We're a little nervous to remove the submodule. How have other teams dealt with this naming conflict? Thanks, |
Signed-off-by: Keaty Gross <kgross@pivotal.io>
Contributor
|
Merged into develop |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey cf-mysql, as part of microPCF work we're colocating components/services that have never before been colocated. As we go we're running into issues where jobs and packages have the same name across releases and/or are running on the same port. This PR addresses the conflicts we've discovered and will facilitate cf-mysql-release running on microPCF.
One of the packages with a name conflict was the "common" package. Our solution was to put the contents of the submodule in a new package called "cf-mysql-common."
Thanks!