Conversation
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/170268541 The labels on this github issue will be updated when the story is started. |
ssisil
approved these changes
Dec 16, 2019
Member
|
Hm, it might be nice to refactor all the internal logic depending on state before/when we merge this... |
Member
|
@Gerg do you mine rebasing this? |
ewrenn8
approved these changes
Jul 28, 2020
Contributor
ewrenn8
left a comment
ewrenn8
left a comment
There was a problem hiding this comment.
I will miss the state field.
Gerg
force-pushed
the
remove_deployment_state
branch
2 times, most recently
from
64fc98d to
e3ee0d5
Compare
Gerg
force-pushed
the
remove_deployment_state
branch
2 times, most recently
from
a3bd998 to
5dc532d
Compare
- Replaced by status.value and status.reason - Deployment state is still used internally Authored-by: Greg Cobb <gcobb@pivotal.io>
Gerg
force-pushed
the
remove_deployment_state
branch
from
5dc532d to
2935a84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently marked as deprecated in the docs. Not sure what the blockers are for removing it, but it might make sense to remove when GAing deployments.
I removed state from the presenter, but did not touch any of the internal logic that currently depends on deployment state. Not sure if y'all were thinking of doing a larger, internal refactor as part of removing the field. Examples where it is used:
cloud_controller_ng/lib/cloud_controller/deployment_updater/dispatcher.rb
Lines 14 to 15 in 8af9682
cloud_controller_ng/app/actions/deployment_cancel.rb
Lines 33 to 35 in 8af9682