Skip to content

Ignore updates of buildpack (e.g. second cf push)#1604

Merged
sethboyles merged 1 commit intocloudfoundry:masterfrom
akhinos:ignore-buildpack-update
May 6, 2020
Merged

Ignore updates of buildpack (e.g. second cf push)#1604
sethboyles merged 1 commit intocloudfoundry:masterfrom
akhinos:ignore-buildpack-update

Conversation

@kramerul
Copy link
Copy Markdown
Contributor

@kramerul kramerul commented May 6, 2020

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

When running a cf push twice with a manifest.yml which includes a buildpacks setting, the second push fails with undefined method 'buildpacks='

  • An explanation of the use cases your change solves

This also relates to cloudfoundry/cf-for-k8s#88 which was closed.
The current behaviour is not consitent. The first push succeeds and the second fails. It should either fail in both cases or succeed in both cases. We would vote for the later.

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the master branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests
    Not require for this simple change.

Co-authored-by: Ulrich Kramer <u.kramer@sap.com>
@cf-gitbot
Copy link
Copy Markdown

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/172695119

The labels on this github issue will be updated when the story is started.

@sethboyles
Copy link
Copy Markdown
Member

Also fails with cf push appname -b buildpack. It's interesting that we accept buildpack arguments at all when they do nothing, but I agree we should at least be consistent. Thanks for the PR!

@sethboyles sethboyles merged commit 487c3ce into cloudfoundry:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants