Ignore updates of buildpack (e.g. second cf push)#1604
Merged
sethboyles merged 1 commit intocloudfoundry:masterfrom May 6, 2020
akhinos:ignore-buildpack-update
Merged
Ignore updates of buildpack (e.g. second cf push)#1604sethboyles merged 1 commit intocloudfoundry:masterfrom akhinos:ignore-buildpack-update
sethboyles merged 1 commit intocloudfoundry:masterfrom
akhinos:ignore-buildpack-update
Conversation
Co-authored-by: Ulrich Kramer <u.kramer@sap.com>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/172695119 The labels on this github issue will be updated when the story is started. |
Member
|
Also fails with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
When running a
cf pushtwice with amanifest.ymlwhich includes abuildpackssetting, the second push fails withundefined method 'buildpacks='This also relates to cloudfoundry/cf-for-k8s#88 which was closed.
The current behaviour is not consitent. The first push succeeds and the second fails. It should either fail in both cases or succeed in both cases. We would vote for the later.
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests
Not require for this simple change.